-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Craftable Item List #1334
Conversation
# Conflicts: # src/main/java/at/hannibal2/skyhanni/utils/renderables/Renderable.kt
# Conflicts: # src/main/java/at/hannibal2/skyhanni/utils/renderables/Renderable.kt
# Conflicts: # src/main/java/at/hannibal2/skyhanni/utils/renderables/Renderable.kt
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
Conflicts have been resolved! 🎉 |
src/main/java/at/hannibal2/skyhanni/config/features/inventory/CraftableItemListConfig.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the idea of this feature but right now the Include Sacks option needs some work. When enabling it i get a list that is 176 items long. (I also dont have much in my sacks or many sacks so for others it would be much more). It would be cool to have ways to sort this like we do for chest value. {price per (asc, desc) and amount craftable (asc, desc)} Also a way to "scroll" down that list if everything does not fit on the screen.
src/main/java/at/hannibal2/skyhanni/features/inventory/craft/CraftableItemList.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/inventory/craft/CraftableItemList.kt
Outdated
Show resolved
Hide resolved
…raftableItemList.kt Co-authored-by: CalMWolfs <94038482+CalMWolfs@users.noreply.github.com>
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
Conflicts have been resolved! 🎉 |
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
# Conflicts: # src/main/java/at/hannibal2/skyhanni/SkyHanniMod.kt
Conflicts have been resolved! 🎉 |
The display now sorts by price per item, not multiplying per amount craftable. |
Depends on
Image
What
Add Craftable Items List.
Changelog New Features