-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Plot Menu Highlighting #1181
Feature: Plot Menu Highlighting #1181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested in game, just code cleanup ideas
src/main/java/at/hannibal2/skyhanni/config/features/garden/GardenConfig.java
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/garden/inventory/PlotMenuHighlighting.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/garden/inventory/PlotMenuHighlighting.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/garden/inventory/PlotMenuHighlighting.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/garden/inventory/PlotMenuHighlighting.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/garden/inventory/PlotMenuHighlighting.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/features/garden/inventory/PlotMenuHighlighting.kt
Outdated
Show resolved
Hide resolved
(resolved convo for pull) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a personal preference: move the events first, then the utils functions.
...ain/java/at/hannibal2/skyhanni/features/garden/inventory/plots/GardenPlotMenuHighlighting.kt
Outdated
Show resolved
Hide resolved
...ain/java/at/hannibal2/skyhanni/features/garden/inventory/plots/GardenPlotMenuHighlighting.kt
Outdated
Show resolved
Hide resolved
...ain/java/at/hannibal2/skyhanni/features/garden/inventory/plots/GardenPlotMenuHighlighting.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/garden/PlotMenuHighlightingConfig.java
Outdated
Show resolved
Hide resolved
...ain/java/at/hannibal2/skyhanni/features/garden/inventory/plots/GardenPlotMenuHighlighting.kt
Outdated
Show resolved
Hide resolved
...ain/java/at/hannibal2/skyhanni/features/garden/inventory/plots/GardenPlotMenuHighlighting.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does work with plots, does not show the plot I'm standing on for me
...ain/java/at/hannibal2/skyhanni/features/garden/inventory/plots/GardenPlotMenuHighlighting.kt
Outdated
Show resolved
Hide resolved
src/main/java/at/hannibal2/skyhanni/config/features/garden/PlotMenuHighlightingConfig.java
Show resolved
Hide resolved
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add support for "currently pasting" in the future
Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
What
Added Plot Menu Highlighting Feature, highlights plots in the desk menu "Configure Plots" based on 4 different statuses:
Changelog New Features