Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chain: double check invalidate operaiton #744

Open
pinheadmz opened this issue Jun 20, 2022 · 0 comments
Open

chain: double check invalidate operaiton #744

pinheadmz opened this issue Jun 20, 2022 · 0 comments

Comments

@pinheadmz
Copy link
Member

hsd/lib/blockchain/chain.js

Lines 2102 to 2105 in 914f625

async _invalidate(hash) {
await this._replay(hash, false);
this.setInvalid(hash);
}

I wonder if we should invalidate before we replay?

see also
bcoin-org/bcoin#277
and
bcoin-org/bcoin#276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant