Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet race condition where coins are double-spent #503

Closed
pinheadmz opened this issue Aug 21, 2020 · 1 comment
Closed

wallet race condition where coins are double-spent #503

pinheadmz opened this issue Aug 21, 2020 · 1 comment

Comments

@pinheadmz
Copy link
Member

h/t @turbomaze

Issue sounds a lot like bcoin-org/bcoin#914 but that patch didn't solve.

  • Are there multiple places where a TX is created and funded in the wallet in hsd requiring more locks in different places?
  • Is there a race condition due to the time it takes from tx funding -> txdb insertion? (If I recall, the tx goes through the mempool first before inserting into txdb) maybe the coins are not marked as spent until its too late.
@nodech
Copy link
Contributor

nodech commented Nov 2, 2023

This sounds like the issue solved by the PR: #845

writeLock mentioned in the PR bcoin-org/bcoin#914 is not related to the funding, it instead only applies to wallet entries itself, like: encrypt/decrypt, change account/add account etc.

@nodech nodech closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants