From 25cce5d4cba7930255264ade37741a863fe93441 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?netop=3A//=E3=82=A6=E3=82=A8=E3=83=8F?= <1288356+NetOpWibby@users.noreply.github.com> Date: Wed, 2 Nov 2022 08:07:15 -0700 Subject: [PATCH 1/6] Fix npm warning Apparently, `--omit-dev` should be used over `--production`. --- docs/install.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/install.md b/docs/install.md index 8c393e38f..a359666f3 100644 --- a/docs/install.md +++ b/docs/install.md @@ -33,7 +33,7 @@ keys. You can get keys following [Security](../SECURITY.md) document. ``` git clone --depth 1 --branch latest https://github.com/handshake-org/hsd.git cd hsd -npm install --production +npm install --omit-dev # run full node in foreground with default configuration ./bin/hsd ``` From 67240f84db026281e265ee1c6e17657cf25564b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?netop=3A//=E3=82=A6=E3=82=A8=E3=83=8F?= <1288356+NetOpWibby@users.noreply.github.com> Date: Fri, 4 Nov 2022 16:41:16 -0700 Subject: [PATCH 2/6] Update docs/install.md Co-authored-by: Roma <81729714+rtdev-com@users.noreply.github.com> --- docs/install.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/install.md b/docs/install.md index a359666f3..53a43b12d 100644 --- a/docs/install.md +++ b/docs/install.md @@ -33,7 +33,7 @@ keys. You can get keys following [Security](../SECURITY.md) document. ``` git clone --depth 1 --branch latest https://github.com/handshake-org/hsd.git cd hsd -npm install --omit-dev +npm install --omit=dev # run full node in foreground with default configuration ./bin/hsd ``` From f56332c267c3268645f72cb65908346887f24f15 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?netop=3A//=E3=82=A6=E3=82=A8=E3=83=8F?= <1288356+NetOpWibby@users.noreply.github.com> Date: Sat, 5 Nov 2022 17:37:11 -0700 Subject: [PATCH 3/6] Update Dockerfile --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index 97ed6d888..057597551 100644 --- a/Dockerfile +++ b/Dockerfile @@ -6,7 +6,7 @@ COPY package.json /opt/hsd # Install build dependencies and compile. FROM base AS build RUN apk add --no-cache g++ gcc make python3 -RUN npm install --production +RUN npm install --omit=dev FROM base ENV PATH="${PATH}:/opt/hsd/bin:/opt/hsd/node_modules/.bin" From a51538224691aaf336a816391855fc554fea0adf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?netop=3A//=E3=82=A6=E3=82=A8=E3=83=8F?= <1288356+NetOpWibby@users.noreply.github.com> Date: Sat, 5 Nov 2022 17:37:38 -0700 Subject: [PATCH 4/6] Update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index db84d605e..4c6c2dd54 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -20,7 +20,7 @@ npm run build-docs # also defined in package.json ## Testing [bmocha](https://www.npmjs.com/package/bmocha) will be installed as a -"developer dependency" if installed without the `--production` flag. The +"developer dependency" if installed without the `--omit=dev` flag. The complete built-in testing suite can be run with the command: ``` From f78947ec20f28f54a602a4d2d96ca537cec160b7 Mon Sep 17 00:00:00 2001 From: Matthew Zipkin Date: Fri, 11 Nov 2022 11:42:42 -0500 Subject: [PATCH 5/6] ci: remove node v 12 --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2c2df3900..cf55eb4de 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -54,7 +54,7 @@ jobs: strategy: matrix: os: [ubuntu-latest] - node: [12.x, 14.x, 16.x, 18.x] + node: [14.x, 16.x, 18.x] steps: - uses: actions/checkout@v3 From 8f062c3e1eba0f04abd2771cfe9106d9adbcdc1c Mon Sep 17 00:00:00 2001 From: Matthew Zipkin Date: Fri, 11 Nov 2022 12:58:24 -0500 Subject: [PATCH 6/6] test: skip external DNS lookup test for now --- test/net-lookup-test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/net-lookup-test.js b/test/net-lookup-test.js index 28ed65616..9252345ce 100644 --- a/test/net-lookup-test.js +++ b/test/net-lookup-test.js @@ -8,7 +8,7 @@ const main = Network.get('main'); const notAHost = 'not-a-domain.not-a-domain'; -describe('Lookup', function() { +describe.skip('Lookup', function() { this.timeout(10000); it('should lookup seed', async () => { for (const host of main.seeds) {