Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: handlebars-lang/handlebars-parser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: MichalBryxi/handlebars-parser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: mb/20-experiments
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 11 files changed
  • 1 contributor

Commits on Apr 15, 2025

  1. fix: CJS build issue fix 

    Without this anything that uses ember-cli-addon-docs then explodes with:

```
require() of ES Module /Users/michal/ember/ember-intl/node_modules/.pnpm/@handlebars+parser@file+..+handlebars-parser/node_modules/@handlebars/parser/dist/cjs/index.js not supported.
Instead change the require of index.js in null to a dynamic import() which is available in all CommonJS modules.
```
    @MichalBryxi
    MichalBryxi committed Apr 15, 2025
    Configuration menu
    Copy the full SHA
    293b6af View commit details
    Browse the repository at this point in the history

  2. fix: Because we can't have nice things 

    Until this is merged: zaach/jison#352
    @MichalBryxi
    MichalBryxi committed Apr 15, 2025
    Configuration menu
    Copy the full SHA
    9656e15 View commit details
    Browse the repository at this point in the history

  3. fix: This feels correct?

    @MichalBryxi
    MichalBryxi committed Apr 15, 2025
    Configuration menu
    Copy the full SHA
    6e70a9d View commit details
    Browse the repository at this point in the history

  4. fix: After the the thing builds

    @MichalBryxi
    MichalBryxi committed Apr 15, 2025
    Configuration menu
    Copy the full SHA
    54bf0d5 View commit details
    Browse the repository at this point in the history

  5. fix: revert removing module

    @MichalBryxi
    MichalBryxi committed Apr 15, 2025
    Configuration menu
    Copy the full SHA
    86606f3 View commit details
    Browse the repository at this point in the history

  6. fix: import is back to ESM

    @MichalBryxi
    MichalBryxi committed Apr 15, 2025
    Configuration menu
    Copy the full SHA
    9193bd0 View commit details
    Browse the repository at this point in the history

  7. fix: js / cjs shenanigans 

    - This builds ...
    @MichalBryxi
    MichalBryxi committed Apr 15, 2025
    Configuration menu
    Copy the full SHA
    b198c67 View commit details
    Browse the repository at this point in the history
Loading