Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation clarifying hammer.js vs. 300ms delay #551

Closed
eliotsykes opened this issue May 11, 2014 · 13 comments
Closed

Documentation clarifying hammer.js vs. 300ms delay #551

eliotsykes opened this issue May 11, 2014 · 13 comments

Comments

@eliotsykes
Copy link

Docs would be improved with some clarification in the wiki on if hammer.js takes away the 300ms click delay or if another solution (e.g. fastclick) is recommended (or perhaps it isn't?) or how hammer.js can be configured to remove the delay.

If you can clarify it here or point me in the right direction, I'm happy to write the wiki page.

Kind regards and thanks for making hammer.js!
Eliot

@shai126
Copy link

shai126 commented May 21, 2014

+1

@jtangelder
Copy link
Member

Hammer doesnt remove the click delay for the click events, but, it does 'remove' it when you'll just use tap for the clicking on links.

@eliotsykes
Copy link
Author

Ok, so would hammer.js benefit from a wiki page to document this? If yes, how does the outline below sound?

Title: Removing click delays

Sections:

  1. What the click delay is and why it exists
  2. Remove click delay with hammer.js' tap event (overview and examples of using it on anchors and buttons)
  3. (Not?) using hammer.js and fastclick.js together (is this a bad idea?) (example)

@laktak
Copy link

laktak commented Jun 16, 2014

+1

2 similar comments
@porjo
Copy link

porjo commented Jun 17, 2014

+1

@ganchenkor
Copy link

+1

@jtangelder
Copy link
Member

I will look into this! 👍

@StreetStrider
Copy link

So, for clarification:

  1. using tap is well enough to eliminate delay.
  2. fastclick and hammer do not intervene interfere with each other.
    As many people above, I think documentation should mention this, too. Thanks.

@xmnboy
Copy link

xmnboy commented Sep 14, 2014

The term "intervene" is confusing here. Do you mean that fastclick and hammer do not interfere with each other, so they can be used together? Or, do you mean that fastclick and hammer will interfere with each other, so they should not be used together?

The reason I ask is because the term "intervene" is an active verb, it means to actively interfere or intercede. The prior comments also are not clear regarding whether or not it is okay to use the two (hammer and fastclick) libraries together.

@StreetStrider
Copy link

@xmnboy, hi.
I mean the first one. Sorry for confusing. So both of them would not break each other, and they can be used together.

@xmnboy
Copy link

xmnboy commented Sep 16, 2014

Thanks for the clarification. 👍

@corgrath
Copy link

Did a page get created for this?

@runspired
Copy link
Contributor

There is no page for this. Using tap as a fastclick presents other issues. You'll usually need to bust the clicks that do occur later, but clicks on inputs and buttons on mobile often need to be allowed. There's lots of tricky corner cases, so in general with the current (2.0.4) version of Hammer, tap is not a drop in replacement for fastclick.

Closing this in favor of actually producing a solution to these cases in #808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants