Overhaul #145
Overhaul #145
Conversation
|
Elixir 1.6 needs OTP 19 or higher. I made a pull request #146 to test all Elixir/OTP compatible versions from 1.3 and upwards. You could merge that and see what happens. |
|
I dunno, they fail locally too, with OTP 20 |
|
The ssl test fails because of a bad certificate, and should be removed. The other test that fails does not fail if I replace the test file with the one from master, so it's something in the test itself. I see that you have changed the test to create and remove the |
|
I don't really have time to work on it now.. |
|
I can make a new version of this on top of the current master, if you don't have time. Maybe we should fix one thing at a time. |
|
Please do make a new one then |
|
We should probably also use the new "mix format" to make merging easier in the future. I'll make a list of things to fix in a new issue and then we can tick them off. |
This includes: * Fix missing parens errors * Creation/Removal of the `test` database for each test suit * Removal of a test that depends on the external httpbin service (unreliable) * Removal of a JS test (causes worker crash sometimes) * Making most of the tests synchronious, because of database creation/dropping * Traling whitespace removal * Comparing geospatial values in delta instead of plain == Couldn't get the SSL and reconnection test to work
|
Fixed conflects there were there and rebased on master. Tests should pass i think. |
|
Im not sure how geospatial tests work but they fail.. |
I'm not sure if this library is dead or not, but i've done some oberhauling on it, it should fix most of the warnings and make tests pass (except the 2 i didn't figure out how to fix)