Add support for user authentication #117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't compile with Elixir < 1.2. Maybe you should update your |
|
I've updated
|
|
Awesome. I'll take a look as soon as I am able. I appreciate the help! |
|
Can we get a test for user auth? Otherwise, this looks great. |
|
Will write a few tests asap. |
* connection authenticates with admin. * connection fails to authenticate with invalid user. * connection authenticates with newly created user.
|
Any news on this one? I'd love to see this functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add authentication via
:userand:passoptions.User accounts have been added to RethinkDB in version 2.3. The default options for connecting are
[user: "admin", pass: ""]. The old authentication (using:auth_key) has been removed.If you wish to provide the old authentication method for backward compatibility, i will update my PR to do so 😺.