Skip to content

Commit 2dbca65

Browse files
committed
fix. typing and f-string
1 parent 51b82ef commit 2dbca65

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

src/solid/solid_api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ def read_folder(self, url, options: ReadFolderOptions = ReadFolderOptions()) ->
215215

216216
return parsed_folder
217217

218-
def get_item_links(self, url, options: Dict = {}) -> Response:
218+
def get_item_links(self, url, options: Dict = {}) -> Links:
219219
if not self.item_exists(url):
220220
raise Exception(f'Item not found: {url}')
221221

src/solid/utils/api_util.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
from enum import Enum
2-
from typing import List
2+
from typing import List, Dict
33
import re
44

55

@@ -68,7 +68,7 @@ def get_links_from_response(response) -> dict:
6868
else:
6969
return parse_link_header(link_header, response.url)
7070

71-
def parse_link_header(link_header: str, item_url) -> dict:
71+
def parse_link_header(link_header: str, item_url) -> Dict:
7272
link_dict = {}
7373
link_header_list = parse_link_header_to_array(link_header)
7474
if len(link_header_list) > 0:
@@ -85,14 +85,14 @@ def parse_link_header(link_header: str, item_url) -> dict:
8585

8686
return link_dict
8787

88-
def parse_link_header_to_array(link_header: str) -> list:
88+
def parse_link_header_to_array(link_header: str) -> List:
8989
if (not link_header): return
9090
linkexp = '<[^>]*>\s*(\s*;\s*[^()<>@,;:"/[\]?={} \t]+=(([^\(\)<>@,;:"\/\[\]\?={} \t]+)|("[^"]*")))*(,|$)'
9191
match = re.finditer(linkexp, link_header)
9292
links = [x.group() for x in match]
9393
return links
9494

95-
def url_join(given, base):
95+
def url_join(given, base) -> str:
9696
base = str(base)
9797
base_hash = base.find('#')
9898
if (base_hash > 0):

tests/integration_test_solid_api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,4 +169,4 @@ def test_file():
169169

170170
# get item links
171171
links = api.get_item_links(patchedUrl)
172-
assert links == {'acl': "{}.acl".format(patchedUrl), 'meta': "{}.meta".format(patchedUrl)}
172+
assert links == {'acl': f'{patchedUrl}.acl', 'meta': f'{patchedUrl}.meta'}

0 commit comments

Comments
 (0)