Fix two trivial build errors #8467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
steven-johnson
commented
Nov 6, 2024
steven-johnson
commented
- Missing #include in halide_test_dirs.h
- ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result] in parallel_scenarios.cpp
- Missing #include in halide_test_dirs.h - ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result] in parallel_scenarios.cpp
zvookin
reviewed
Nov 6, 2024
| @@ -37,7 +37,7 @@ int main(int argc, char **argv) { | |||
|
|
|||
| auto bench_one = [&]() { | |||
| auto t1 = std::chrono::high_resolution_clock::now(); | |||
| callable(i, o, memory_limit, in, out); | |||
| (void)callable(i, o, memory_limit, in, out); | |||
There was a problem hiding this comment.
This actually returns an error code doesn't it? Might be worth checking it outside the timing scope.
There was a problem hiding this comment.
We haven't overloaded halide_error in this test, so it actually just always returns zero (or aborts before returning)
There was a problem hiding this comment.
Added comment
abadams
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.