Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vulkan] Fix Vulkan SIMT mappings for GPU loop vars. #8259

Merged
merged 3 commits into from
Jun 5, 2024
Merged

[vulkan] Fix Vulkan SIMT mappings for GPU loop vars. #8259

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
120e077
Fix Vulkan SIMT mappings for GPU loop vars. Previous refactoring
Jun 3, 2024
4a45f3c
trigger buildbots
steven-johnson Jun 3, 2024
2c9e781
Avoid formatting the GPU kernel to a string for Vulkan (since it's bi…
Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Avoid formatting the GPU kernel to a string for Vulkan (since it's bi… 
…nary SPIR-V needs to remain intact).
  • Loading branch information
Derek Gerstmann committed Jun 5, 2024
commit 2c9e78169713d598917581aa64d9e8da33734d55
5 changes: 3 additions & 2 deletions src/CodeGen_C.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,8 +1155,9 @@ void CodeGen_C::compile(const Buffer<> &buffer) {
bool is_constant = buffer.dimensions() != 0;

// If it is an GPU source kernel, we would like to see the actual output, not the
// uint8 representation. We use a string literal for this.
if (ends_with(name, "gpu_source_kernels")) {
// uint8 representation. We use a string literal for this. Since the Vulkan backend
// actually generates a SPIR-V binary, keep it as raw data to avoid textual reformatting.
if (ends_with(name, "gpu_source_kernels") && !target.has_feature(Target::Vulkan)) {
stream << "static const char *" << name << "_string = R\"BUFCHARSOURCE(";
stream.write((char *)b.host, num_elems);
stream << ")BUFCHARSOURCE\";\n";
Expand Down
Loading