It's generally a bad idea for simplifier rules to multiply constants #8234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #8227 but may break other things. Needs thorough testing. Also, there are more rules like this lurking.
steven-johnson
approved these changes
May 25, 2024
|
Ready to land? |
|
I think this one probably needs testing inside Google. We may need more simplifier rules to patch up the holes left by the deleted ones. |
ok, I'll run a full test |
|
So far there are a handful of goldens with apparently-trivial diffs, but no red flags yet |
|
Looks clean inside Google. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8227 but may break other things. Needs thorough testing.
Also, there are more rules like this lurking.