Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Making HLSL code-gen a couple orders of magnitude faster..." #7737

Closed
wants to merge 1 commit into from

Conversation

abadams
Copy link
Member

@abadams abadams commented Aug 1, 2023

Reverts #7719

@abadams abadams marked this pull request as draft August 1, 2023 22:06
@steven-johnson
Copy link
Contributor

So it looks like that PR did not inject the bug -- so maybe WinWorker2 really is just too old to be useful here (which wouldn't be surprising). To be a broken record here, we really need more Windows bots; WinWorker3 is decent when it is running but it has proven to be unstable over time. Desperately need Windows testing we can rely on and stop spending endless person-hours fixing.

@steven-johnson
Copy link
Contributor

See halide/build_bot#250

@steven-johnson steven-johnson deleted the revert-7719-slomp/hlsl-codegen-speedup branch August 2, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants