Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

halide_popcount<uint64_t> is broken #7313

Merged
merged 1 commit into from
Jan 31, 2023
Merged

halide_popcount<uint64_t> is broken #7313

merged 1 commit into from
Jan 31, 2023

Conversation

steven-johnson
Copy link
Contributor

Would not compile for Win32 or any other compiler without __builtin_popcountll available. (How did this get checked in without being tested on MSVC?)

@steven-johnson
halide_popcount<uint64_t> is broken
5dc9df4 
Would not compile for Win32 or any other compiler without __builtin_popcountll available. (How did this get checked in without being tested on MSVC?)
@steven-johnson steven-johnson requested a review from vksnk January 31, 2023 19:20
@steven-johnson steven-johnson mentioned this pull request Jan 31, 2023
Merged
vksnk
vksnk approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@vksnk vksnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the breakage, I merged it in without making sure that actual buildbots are green.

@steven-johnson
Copy link
Contributor Author

Gotcha, yeah, Windows bots were in a worse-than-usual state yesterday, hopefully will be back to OK after this lands

@Aelphy
Copy link
Contributor

Aelphy commented Jan 31, 2023

Sorry, my fault.

@steven-johnson steven-johnson merged commit beba53a into main Jan 31, 2023
@steven-johnson steven-johnson deleted the srj/popcnt branch January 31, 2023 21:08
ardier pushed a commit to ardier/Halide-mutation that referenced this pull request Mar 3, 2024
@steven-johnson @ardier
halide_popcount<uint64_t> is broken (halide#7313)
d4f1852 
Would not compile for Win32 or any other compiler without __builtin_popcountll available. (How did this get checked in without being tested on MSVC?)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vksnk vksnk vksnk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steven-johnson @Aelphy @vksnk