fuzz tests call ConsumeIntegralInRange() incorrectly

[steven-johnson]

ConsumeIntegralInRange() returns a value in the range [min, max], but in several cases we call it in the form [min, max+1] (e.g. simplify.cpp:102, which should be (0, op_count - 1). This causes intermittent segfaults, usually only in -O3 mode. We should examine all the extant calls to ConsumeIntegralInRange() to verify/fix incorrect usage. attn @silvergasp

[nathaniel-brough]

Ah my bad, I should have paid closer attention from the get go. I'll use/comment on the original PR #7512 to double check everything.

[steven-johnson]

as they say, there are 2 hard problems in computer science: cache invalidation, naming things, and off-by-1 errors

[nathaniel-brough]

Haha, I'll have to borrow that joke