Merge branch 'main' into srj/cmake-jit-generators

.clang-tidy

@@ -19,6 +19,7 @@ Checks: >
     bugprone-dangling-handle,
     bugprone-dynamic-static-initializers,
     -bugprone-easily-swappable-parameters,
+    -bugprone-empty-catch,
     -bugprone-exception-escape,
     bugprone-fold-init-type,
     bugprone-forward-declaration-namespace,
@@ -35,8 +36,10 @@ Checks: >
     bugprone-misplaced-pointer-arithmetic-in-alloc,
     bugprone-misplaced-widening-cast,
     bugprone-move-forwarding-reference,
+    bugprone-multiple-new-in-one-expression,
     bugprone-multiple-statement-macro,
-    -bugprone-narrowing-conversions,,
+    -bugprone-narrowing-conversions,
+    bugprone-non-zero-enum-to-bool-conversion,
     bugprone-no-escape,
     bugprone-not-null-terminated-result,
     bugprone-parent-virtual-call,
@@ -63,6 +66,7 @@ Checks: >
     bugprone-suspicious-semicolon,
     bugprone-suspicious-string-compare,
     bugprone-swapped-arguments,
+    bugprone-switch-missing-default-case,
     bugprone-terminating-continue,
     bugprone-throw-keyword-missing,
     bugprone-too-small-loop-variable,
@@ -71,16 +75,25 @@ Checks: >
     bugprone-undelegated-constructor,
     bugprone-unhandled-exception-at-new,
     bugprone-unhandled-self-assignment,
+    bugprone-unique-ptr-array-mismatch,
+    bugprone-unsafe-functions,
     bugprone-unused-raii,
     bugprone-unused-return-value,
     bugprone-use-after-move,
     bugprone-virtual-near-miss,
 
     clang-diagnostic-shadow-field,
 
+    cppcoreguidelines-avoid-capturing-lambda-coroutines,
+    cppcoreguidelines-misleading-capture-default-by-value,
+    -cppcoreguidelines-missing-std-forward,  # TODO: consider enabling
+    cppcoreguidelines-rvalue-reference-param-not-moved,
+
     misc-confusable-identifiers,
     -misc-const-correctness,
     misc-definitions-in-headers,
+    misc-header-include-cycle,
+    -misc-include-cleaner,
     misc-misleading-bidirectional,
     misc-misleading-identifier,
     misc-misplaced-const,
@@ -115,6 +128,7 @@ Checks: >
     -modernize-replace-random-shuffle,
     -modernize-return-braced-init-list,
     -modernize-shrink-to-fit,
+    -modernize-type-traits,
     -modernize-unary-static-assert,
     -modernize-use-auto,
     modernize-use-bool-literals,
@@ -126,11 +140,13 @@ Checks: >
     -modernize-use-noexcept,
     modernize-use-nullptr,
     modernize-use-override,
+    -modernize-use-std-print,
     -modernize-use-trailing-return-type,
     -modernize-use-transparent-functors,
     -modernize-use-uncaught-exceptions,
-    -modernize-use-using
+    -modernize-use-using,
 
+    performance-avoid-endl,
     performance-faster-string-find,
     performance-for-range-copy,
     performance-implicit-conversion-in-loop,
@@ -141,13 +157,16 @@ Checks: >
     performance-move-constructor-init,
     performance-no-automatic-move,
     -performance-no-int-to-ptr,
+    performance-noexcept-destructor,
     performance-noexcept-move-constructor,
+    performance-noexcept-swap,
     performance-trivially-destructible,
     performance-type-promotion-in-math-fn,
     performance-unnecessary-copy-initialization,
     performance-unnecessary-value-param,
 
     readability-avoid-const-params-in-decls,
+    -readability-avoid-unconditional-preprocessor-if,
     readability-braces-around-statements,
     readability-const-return-type,
     -readability-container-contains,
@@ -170,6 +189,7 @@ Checks: >
     readability-misplaced-array-index,
     -readability-named-parameter,
     -readability-non-const-parameter,
+    -readability-operators-representation,
     readability-qualified-auto,
     readability-redundant-access-specifiers,
     readability-redundant-control-flow,

.github/workflows/presubmit.yml

@@ -18,11 +18,11 @@ jobs:
     runs-on: ubuntu-20.04
     steps:
       - uses: actions/checkout@v3
-      - uses: DoozyX/clang-format-lint-action@v0.16.2
+      - uses: DoozyX/clang-format-lint-action@v0.17
         with:
           source: '.'
           extensions: 'h,c,cpp'
-          clangFormatVersion: 16
+          clangFormatVersion: 17
   # As of Aug 2023, the macOS runners have more RAM (14GB vs 7GB) and CPU (3 cores vs 2)
   # than the Linux and Windows runners, so let's use those instead, since clang-tidy is
   # a bit of a sluggard
@@ -36,14 +36,14 @@ jobs:
           # from apt.llvm.org
           # wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | apt-key add -
           sudo apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 15CF4D18AF4F7421
-          sudo apt-add-repository "deb https://apt.llvm.org/$(lsb_release -sc)/ llvm-toolchain-$(lsb_release -sc)-16 main"
+          sudo apt-add-repository "deb https://apt.llvm.org/$(lsb_release -sc)/ llvm-toolchain-$(lsb_release -sc)-17 main"
           sudo apt-get update
-          sudo apt-get install llvm-16 clang-16 liblld-16-dev libclang-16-dev clang-tidy-16 ninja-build
+          sudo apt-get install llvm-17 clang-17 liblld-17-dev libclang-17-dev clang-tidy-17 ninja-build
       - name: Run clang-tidy
         run: |
-          export CC=clang-16
-          export CXX=clang++-16
-          export CLANG_TIDY_LLVM_INSTALL_DIR=/usr/lib/llvm-16
+          export CC=clang-17
+          export CXX=clang++-17
+          export CLANG_TIDY_LLVM_INSTALL_DIR=/usr/lib/llvm-17
           export CMAKE_GENERATOR=Ninja
           ./run-clang-tidy.sh
   check_cmake_file_lists:

.gitignore

@@ -202,6 +202,9 @@ install_manifest.txt
 # Ninja files
 *.ninja*
 
+# Package managers
+vcpkg_installed/
+
 ################################################################################
 ## IDE directories and metadata