-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update agent for pydle 0.8.5+ / python 3.7 fixes #3
Comments
I am currently running a version of pydle with that pull request applied, and it seems to work after commenting out the |
An update for Pydle should be released soon resolving the 3.7 incompatability. I have also re-implemented |
pydle |
Thanks for the heads up on the fix! Leaving issue open since the agent still needs to be updated, but that thankfully resolved the main problem. |
No worries. Just a heads up version 0.8.5 has a couple show-stopping bugs revolving around reconnection handling and suggest using Sorry for any inconvenience this may cause! |
Theirc
agent is completely broken on 3.7 sinceasync
was made a reserved keyword, thus breaking Pydle.See Pydle issue here: shizmob/pydle#76And the relevant pull request that sort of fixes it here: shizmob/pydle#79I see two courses of action for this:1. Write a new IRC agent using a different backing library (not a bad idea for variety's sake)2. Wait it out for a fix, and warn users not to run with 3.7 (possibly put a warning in the code)Pydle issues have been resolved and now plays nice with 3.7 again.
However, the agent needs to be updated for these changes, as we now need to await on the handling async functions.
Further suggestion: investigate notifying users if they have potentially incompatible python/pydle versions? Make 0.8.5 mandatory?
The text was updated successfully, but these errors were encountered: