Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agent for pydle 0.8.5+ / python 3.7 fixes #3

Closed
richteer opened this issue Oct 1, 2018 · 5 comments
Closed

Update agent for pydle 0.8.5+ / python 3.7 fixes #3

richteer opened this issue Oct 1, 2018 · 5 comments

Comments

@richteer
Copy link
Contributor

richteer commented Oct 1, 2018

The irc agent is completely broken on 3.7 since async was made a reserved keyword, thus breaking Pydle.

See Pydle issue here: shizmob/pydle#76
And the relevant pull request that sort of fixes it here: shizmob/pydle#79

I see two courses of action for this:
1. Write a new IRC agent using a different backing library (not a bad idea for variety's sake)
2. Wait it out for a fix, and warn users not to run with 3.7 (possibly put a warning in the code)

Pydle issues have been resolved and now plays nice with 3.7 again.

However, the agent needs to be updated for these changes, as we now need to await on the handling async functions.

Further suggestion: investigate notifying users if they have potentially incompatible python/pydle versions? Make 0.8.5 mandatory?

@richteer
Copy link
Contributor Author

richteer commented Oct 1, 2018

I am currently running a version of pydle with that pull request applied, and it seems to work after commenting out the pydle.coroutine lines (as that wrapper lib was removed). Will post further when I have more information.

@theunkn0wn1
Copy link

An update for Pydle should be released soon resolving the 3.7 incompatability.

I have also re-implemented pydle.coroutine as not to require that change on your end, I should have been more careful to observe downstream usages prior to changing the interface. I will be more careful not to change the interface moving forward to minimize the likelihood of breaking things unnecessarily.

@theunkn0wn1
Copy link

pydle v0.8.5 has been released, which resolves the python 3.7 incompatibility.

@richteer
Copy link
Contributor Author

richteer commented Jan 5, 2019

Thanks for the heads up on the fix!

Leaving issue open since the agent still needs to be updated, but that thankfully resolved the main problem.

@richteer richteer changed the title Replace or update Pydle, since it is broken on 3.7 Update agent for pydle 0.8.5+ / python 3.7 fixes Jan 5, 2019
@theunkn0wn1
Copy link

theunkn0wn1 commented Jan 5, 2019

No worries. Just a heads up version 0.8.5 has a couple show-stopping bugs revolving around reconnection handling and suggest using v0.9.0+

Sorry for any inconvenience this may cause!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants