Add error handler

Author: haldarmahesh

src/app.js

@@ -20,15 +20,13 @@ app.use((req, res, next) => {
 });
 
 // error handler
-app.use((err, req, res) => {
-  console.log(err);
-  // set locals, only providing error in development
-  res.locals.message = err.message;
-  res.locals.error = req.app.get('env') === 'development' ? err : {};
-
-  // render the error page
+app.use((err, req, res, next) => {
+  if (!err) {
+    return next();
+  }
   res.status(err.status || 500);
-  res.render('error');
+  res.send({ message: err.message });
+  return res;
 });
 
 module.exports = app;

src/controller/employeesController.js

@@ -2,14 +2,25 @@ const express = require('express');
 
 const router = express.Router();
 const employeeService = require('../service/employeeService');
-/* GET employees listing. */
+/* GET /employees - get list of all employees. */
 router.get('/', (req, res) => res.json(employeeService.getAll()));
-// router.get('/:id', employeeService.ge)
 
+/* GET /employees/:id - get employee by employeeId */
+router.get('/:id', (req, res) => {
+  const employeeId = req.params.id;
+  return res.json(employeeService.getById(employeeId));
+});
+
+/* POST /employees - create a new employee and add in db */
 router.post('/', (req, res) => {
   const newEmployee = req.body;
   return res.json(employeeService.save(newEmployee));
 });
-router.delete('');
+
+/* DELETE /employees/:id - delete an existing employee with id */
+router.delete('/:id', (req, res) => {
+  const employeeId = req.params.id;
+  return res.json(employeeService.getById(employeeId)); // todo convert to do
+});
 
 module.exports = router;

src/repository/employees.js

@@ -0,0 +1,33 @@
+const employeesData = [{
+  id: 'EMP_1',
+  name: 'Mahesh',
+  department: 'IT',
+}];
+function validateEmployee(employee) {
+  if (!(employee.name && employee.department)) {
+    throw new Error('Employee Name and department is required');
+  }
+}
+function getAll() {
+  return employeesData;
+}
+function save(employee) {
+  validateEmployee(employee);
+  const newEmployee = employee;
+  newEmployee.id = `EMP_${employeesData.length + 1}`;
+  employeesData.push(employee);
+  return employee;
+}
+function getById(employeeId) {
+  const employee = employeesData.filter(item => item.id === employeeId);
+  if (employee.length === 0) {
+    throw new Error(`Employee Resource with id: ${employeeId} not found`);
+  }
+  return employee;
+}
+
+module.exports = {
+  getAll,
+  save,
+  getById,
+};

src/repository/employeesRepository.js

@@ -1,13 +1,17 @@
-const employeeRepository = require('../repository/employees');
+const employeeRepository = require('../repository/employeesRepository');
 
 function getAll() {
   return employeeRepository.getAll();
 }
 function save(newEmployee) {
   return employeeRepository.save(newEmployee);
 }
+function getById(employeeId) {
+  return employeeRepository.getById(employeeId);
+}
 
 module.exports = {
   getAll,
+  getById,
   save,
 };