Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slide numbers don't match URL #2067

Closed
Leftium opened this issue Jan 10, 2018 · 2 comments
Closed

Slide numbers don't match URL #2067

Leftium opened this issue Jan 10, 2018 · 2 comments
Labels

Comments

@Leftium
Copy link

Leftium commented Jan 10, 2018

Apparently, the URL is 0-indexed, but the slideNumber starts at 1. It would be less confusing if they used the same numbering system.

Repro steps:

  1. Add option slideNumber: true to https://github.com/hakimel/reveal.js/blob/master/demo.html
  2. Compare URL/slide number in browser

image

@bnjmnt4n
Copy link
Collaborator

It is true that using the same numbering system is less confusing, however the 0-indexed URL system has been in use since the very first version of Reveal and hence it is unlikely that we will switch to a different system.

@Leftium
Copy link
Author

Leftium commented Jan 18, 2018

What about changing the displayed slide numbers to also be 0-indexed? It could be added as an additional option for slideNumber to maintain historical behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants