Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reveal.js Fails to respect aria-hidden=true in content #1656

Closed
malcalevak opened this issue Aug 5, 2016 · 1 comment
Closed

Reveal.js Fails to respect aria-hidden=true in content #1656

malcalevak opened this issue Aug 5, 2016 · 1 comment

Comments

@malcalevak
Copy link

I appreciate that Reveal.js actually has a modicum of accessibility support built into it, however I discovered that the copying of screen content into the aria-status-div ironically doesn't take into account content that's been set to aria-hidden="true" nor content that's display: 'none' for that matter.
I've hacked in code to remedy the aria-hidden capability, but it uses jQuery, so it's not really a solution I could submit. Detecting display status I imagine would be substantially harder, given that it's not likely set inline, but ultimately I believe screen readers aren't supposed to see that content either. It wouldn't surprise me if there's even more accessibility related functionality that should be taken into account, but nothing quite as major as respecting aria-hidden="true"

@hakimel
Copy link
Owner

hakimel commented Oct 5, 2016

This was fixed by @Sonaryr in #1665 and will make its way out with the next release.

@hakimel hakimel closed this as completed Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants