Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting Vault server URL in datasource URL #243

Closed
hairyhenderson opened this issue Jan 25, 2018 · 1 comment
Closed

Support setting Vault server URL in datasource URL #243

hairyhenderson opened this issue Jan 25, 2018 · 1 comment
Labels
enhancement

Comments

@hairyhenderson
Copy link
Owner

Sometimes it's not convenient to have the VAULT_ADDR environment variable set, and it'd be much nicer to just use the datasource URL: vault://vault.example.com:8200/secret/key

I think vault:// should default to HTTPS, but vault+http:// should be maybe made available for test scenarios.
@hairyhenderson hairyhenderson mentioned this issue Mar 3, 2018
Merged
@hairyhenderson
Copy link
Owner Author

Fixed in #251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hairyhenderson