-
Notifications
You must be signed in to change notification settings - Fork 69
Adding ush/hafs_ww3_restart_interp.py for ww3 nc restart interpolation #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/hafsv2p2_baseline
Are you sure you want to change the base?
Adding ush/hafs_ww3_restart_interp.py for ww3 nc restart interpolation #317
Conversation
|
@BinLiu-NOAA Please let me know if you want me to change anything within this PR. |
|
@AliS-Noaa Thanks for developing this capability and initiating this PR! |
ush/hafs_ww3_restart_interp.py
Outdated
| --dst_scrip <dst_scrip.nc> \ | ||
| --mask_file <ww3_grid_a.msk> \ | ||
| --output_file <output.nc> | ||
| """ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AliS-Noaa For the documentation header, could you please help to update this section following an example (https://github.com/hafs-community/HAFS/blob/85d914a50ab6f7aacfc2bbc0e99c172d55095d00/ush/hafs_mom6_gfs_forcings.py#L1C1-L11C81). Thanks!
ush/hafs_ww3_restart_interp.py
Outdated
| dst_mask_values=[0] | ||
| ) | ||
|
|
||
| ################################################### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the indentation of line 105. Thanks!
|
Do we need to address where the fix files are for this now? I don't have any comments on the code itself, although I guess I would say it's fairly light on comments (which maybe is fine?) so maybe a few more comments on the input files and anythingn else you think would be helpful to your future self when this is less fresh. |
|
@BinLiu-NOAA I revised the script and made more comments. I also created the HAFS and GFSv17 wave mesh scrip files and I put them here: /lfs/h2/emc/couple/noscrub/ali.salimi/work/ESMPy/HAFS-SCRIP (on Cactus). |
Description of changes
This adds ush/hafs_ww3_restart_interp.py for interpolating netcdf restart file to HAFS meshes.
Issues addressed (optional)
If this PR addresses one or more issues, please provide link(s) to the issue(s) here.
Contributors (optional)
If others worked on this PR besides the author, please include their user names here (using @Mention if possible).
Tests conducted
This is tested outside of the HAFS workflow using standalone ww3 and also the HAFS team tested the interpolated netcdf restat file within the HAFS workflow.