Skip to content
This repository has been archived by the owner on Jul 6, 2019. It is now read-only.

Make sure all the asm! invocations are volatile #31

Open
farcaller opened this issue May 8, 2014 · 3 comments
Open

Make sure all the asm! invocations are volatile #31

farcaller opened this issue May 8, 2014 · 3 comments
Labels
bug ready

Comments

@farcaller
Copy link
Member

llvm seems to toss around the assembly block unless it's volatile. Given that all asm! blocks must execute at the code point where they are defined, they all should be marked volatile.
@farcaller farcaller added the bug label May 8, 2014
@bgamari
Copy link
Contributor

bgamari commented May 9, 2014

A very good point; this affected lock in #11

@bharrisau
Copy link
Contributor

Loadable lints are coming in, so we can probably make one for this (I'm also thinking we have one for out of date TODOs).

@bharrisau
Copy link
Contributor

note for me: rust-lang/rust#15024

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@farcaller @bharrisau @bgamari