Skip to content

Commit f1594c5

Browse files
committed
feat: upgrade base image to resolve pcheck issues
1. upgrade node.js version from 8.16.0 to 8.16.2 2. upgrade pcheck to support connection string from environment 3. upgrade pcheck to fix connection string contains underscore might not resolve correctly Signed-off-by: BoHong Li <raccoon@hackmd.io>
1 parent 5002ec4 commit f1594c5

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

deployments/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ RUN set -xe && \
1515
yarn.lock webpack.prod.js webpack.htmlexport.js webpack.dev.js webpack.common.js \
1616
config.json.example README.md CONTRIBUTING.md AUTHORS
1717

18-
FROM hackmdio/runtime:1.0.4
18+
FROM hackmdio/runtime:1.0.6
1919
USER hackmd
2020
WORKDIR /home/hackmd/app
2121
COPY --chown=1500:1500 --from=BUILD /home/hackmd/app .

deployments/docker-compose.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ services:
1010
- "database-data:/var/lib/postgresql/data"
1111
restart: always
1212
codimd:
13+
# you can use image or custom build below
14+
# image: nabo.codimd.dev/hackmdio/hackmd:1.4.0
1315
build:
1416
context: ..
1517
dockerfile: ./deployments/Dockerfile

deployments/docker-entrypoint.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ if [[ "$#" -gt 0 ]]; then
88
fi
99

1010
# check database and redis is ready
11-
pcheck -constr "$CMD_DB_URL"
11+
pcheck -env CMD_DB_URL
1212

1313
# run DB migrate
1414
NEED_MIGRATE=${CMD_AUTO_MIGRATE:=true}

0 commit comments

Comments
 (0)