Skip to content

Added Scalingo deployment documentation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2019

Conversation

brandon-welsch
Copy link
Contributor

Added documentation for Scalingo one-click deployment

@Yukaii
Copy link
Member

Yukaii commented Nov 29, 2019

@brandon-welsch I see you provide custom branch deployment description in PR hackmdio/codimd#1360, would you like to add them to docs? 🤩

@Yukaii
Copy link
Member

Yukaii commented Nov 29, 2019

And another question for this, which branch will be used for scarlingo deployment? Is the master branch or the default branch set in GitHub repository?

Take our heroku deployment as an example, it's specified to use master branch because we do releases on master branch, but use develop branch as default branch on GitHub.

@brandon-welsch
Copy link
Contributor Author

brandon-welsch commented Nov 29, 2019

@brandon-welsch I see you provide custom branch deployment description in PR hackmdio/codimd#1360, would you like to add them to docs? 🤩

Good point, I will add it thanks.

And another question for this, which branch will be used for scarlingo deployment? Is the master branch or the default branch set in GitHub repository?

Take our heroku deployment as an example, it's specified to use master branch because we do releases on master branch, but use develop branch as default branch on GitHub.

Scalingo deployment uses the master branch in all cases ;), if a branch was not specified

@Yukaii
Copy link
Member

Yukaii commented Nov 30, 2019

Looks good to me now 😍

Just a reminder that we won't put this online until we do our next release :)

Thanks for your contribution @brandon-welsch !

@brandon-welsch
Copy link
Contributor Author

Thanks to you especially, CodiMD is a tool that I personally love

@Yukaii Yukaii merged commit a5af02e into hackmdio:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants