Refactor minimizeIssueComments() in "Schedule Friday" to avoid secondary rate limit

[t-will-gillis]

Overview

For each of the scheduled runs of "Schedule Friday" since Sept. 13th, the workflow has failed due to the minimizeIssueComments() function exceeding GitHub's secondary rate limit. We need to make changes to the workflow to avoid this error.

Details

Upon review of the September 13th workflow logs, it can be shown that the automation made GraphQL calls 683 times in order to minimize these comments. Since most of these comments have already been closed by an earlier run of this automation, making GraphQL requests to close these already-closed comments is superfluous and contributes to exceeding the rate limit.

Therefore, the proposal is to change the existing limit of closing all comments older than 7 days, to closing comments older than 7 days but more recent than 28 days. This should reduce the total number of comments to process and hopefully will help us to stay under the secondary rate limit.

Action Items

• Review the "Schedule Friday" workflow logs, starting with the September 13th run, and note the error occurring due to the secondary rate limit.

• In add-label.js, locate the following code (near lines 190-200), and replace:

    // If this event is more than 7 days old AND this event is a comment by the GitHub Actions Bot, then hide the comment as outdated.
    if (!isMomentRecent(eventObj.created_at, sevenDayCutoffTime) && eventType === 'commented' && isCommentByBot(eventObj)) { 
      console.log(`Comment ${eventObj.node_id} is outdated (i.e. > 7 days old) and will be minimized.`);
      commentsToBeMinimized.push(eventObj.node_id); // retain node id so its associated comment can be minimized later
    }
  

  with:

    // If this event is more than 7 days but less than 30 days old AND this event is a comment by the GitHub Actions Bot, then hide the comment as outdated.
    if (isMomentRecent(eventObj.created_at, expiredDayCutoffTime) && !isMomentRecent(eventObj.created_at, sevenDayCutoffTime) && eventType === 'commented' && isCommentByBot(eventObj)) { 
      console.log(`Comment ${eventObj.node_id} is outdated (i.e. > 7 days old) and will be minimized.`);
      commentsToBeMinimized.push(eventObj.node_id); // retain node id so its associated comment can be minimized later
    }
  

• After const inactiveUpdatedByDays = 14;, add new line:

  const expiredDays = 30;
  

• After const fourteenDayCutoffTime, add new lines:

  const expiredDayCutoffTime = new Date();
  expiredDayCutoffTime.setDate(expiredDayCutoffTime.getDate() - expiredDays);
  

• Although this issue involves GitHub Actions, testing is not required.

For Merge Team:

• After this issue is merged, move issue ER: Secondary rate limits exceeded in the "Schedule Friday" workflow for several weeks #7561 to "Question / In Review" column with the Ready for Merge Team label.

Resources/Instructions

• This issue was initiated by ER: Secondary rate limits exceeded in the "Schedule Friday" workflow for several weeks #7561.
• Although testing is not required, refer to this outdated Wiki entry for info about the intent of the workflow.