Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER: Refactor Sass/ .scss to latest version after Homepage Launch #6867

Open
1 of 7 tasks
t-will-gillis opened this issue May 21, 2024 · 0 comments
Open
1 of 7 tasks
Labels
Complexity: Large Dependency An issue is blocking the completion or starting of another issue Draft Issue is still in the process of being created ER Emergent Request Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages manual dependency release role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours

Comments

@t-will-gillis
Copy link
Member

t-will-gillis commented May 21, 2024

Dependencies

Emergent Requirement - Problem

Our repo appears to be using an older version of Sass. Updating to the more modern syntax might be a large undertaking that we should do eventually by following the lead from the Internship Design System, but not till after the Homepage Launch.

At the dev meeting 5/20/24, we discussed that as a short-term fix we would revert the github/super-linter@4.8.1 and decline future Dependabot updates temporarily.

Issue you discovered this emergent requirement in

Date discovered

This was discussed at the dev meeting 5/20/24.

Did you have to do something temporarily

  • YES
  • NO

Who was involved

@ExperimentsInHonesty @JessicaLucindaCheng @roslynwythe @marioantonini @t-will-gillis

What happens if this is not addressed

Resources

Recommended Action Items

  • Make a new issue
  • Discuss with team
  • Let a Team Lead know

Potential solutions [draft]

  • In the short term, revert to github/super-linter@4.8.1 and decline future Dependabot updates.
  • In the long term, follow the lead of the Internship Design System ( after the Homepage Launch ) to refactor our .scss files as needed and decide whether to continue with the super-linter.
  • If we continue with super-linter, restart the Dependabot updates - by reopening Bump github/super-linter from 5.0.0 to 6 #6713 (?)
  • Once we know how we want proceed we can formulate a plan to address this.
@t-will-gillis t-will-gillis added role: back end/devOps Tasks for back-end developers Complexity: Large Dependency An issue is blocking the completion or starting of another issue Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages size: 1pt Can be done in 4-6 hours Draft Issue is still in the process of being created ER Emergent Request labels May 21, 2024
@t-will-gillis t-will-gillis changed the title ER: Refactor Sass/ .scss to current version ER: Refactor Sass/ .scss to latest version after Homepage Launch May 21, 2024
@ExperimentsInHonesty ExperimentsInHonesty added this to the x. Technical debt milestone Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large Dependency An issue is blocking the completion or starting of another issue Draft Issue is still in the process of being created ER Emergent Request Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages manual dependency release role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
Development

No branches or pull requests

2 participants