-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PR template with instructions regarding CodeQL annotations #5196
Comments
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
i. Availability: Friday-Sunday 9-27-24 |
Changes have been made. |
I implemented the changes and opened a PR #7546, but after some feedback on the changes I closed it because I would like to ask the following before reopening it. I wanted to suggest adding below "After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations." something similar to: "CodeQL alert annotations can be checked below the submitted PR. You will see something similar to: Click here to see a visual example of the `GitHub actions/checks` below the PR.You can click on show all checks to see CodeQL checks I believe this or something else will make it easier for new developers to understand where to find the Checks and CodeQL alert annotations. But just wanted to point that out because it will affect all devs creating PRs. Should I leave it as it is or add that? |
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the You are receiving this comment because your last comment was before Tuesday, October 8, 2024 at 12:05 AM PST. |
I will address the concern tomorrow on the dev meeting. |
Overview
We need to direct developers to check the PR for annotations resulting from CodeQL (Security and Code Quality) scanning.
Action Items
The text was updated successfully, but these errors were encountered: