Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Organization images list under the Citizen Engagement page so it's dynamic #2475

Closed
6 of 7 tasks
Tracked by #3328
macho-catt opened this issue Nov 11, 2021 · 9 comments · Fixed by #4135
Closed
6 of 7 tasks
Tracked by #3328
Assignees
Labels
Complexity: Medium Feature: Refactor HTML P-Feature: Program Area https://www.hackforla.org/program-areas role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review

Comments

@macho-catt
Copy link
Member

macho-catt commented Nov 11, 2021

Dependency

Overview

We need to update the Citizen Engagement Page so that the data is dynamically rendered using liquid.

Action Items

  • Under the section "Organizations We Work With," update the html so that the images are rendered from the data files
    • Use liquid to loop through the list of images under the partners.yml file
    • Check the program-area property. If the value is "Citizen Engagement" the image should be rendered
    • Be sure to include the alt attribute in the loop
      • The alt text for each image will simply be the name of the organization
  • Ensure that the page still looks and functions the same after the refactor

Merge Team, Technical Lead, or Product Manager

Resources/Instructions

partners.yml
Citizen Engagement Page
citizen-engagement.html
Using liquid with jekyll

@macho-catt macho-catt added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium P-Feature: Program Area https://www.hackforla.org/program-areas Dependency An issue is blocking the completion or starting of another issue Ready for Prioritization Feature: Refactor HTML labels Nov 11, 2021
@github-actions

This comment was marked as outdated.

@JessicaLucindaCheng JessicaLucindaCheng added the size: 1pt Can be done in 4-6 hours label Mar 8, 2022
@jdingeman jdingeman removed the Dependency An issue is blocking the completion or starting of another issue label Feb 19, 2023
@jdingeman

This comment was marked as outdated.

@ExperimentsInHonesty

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed ready for product labels Feb 20, 2023
@jdingeman jdingeman added ready for product and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Feb 24, 2023
@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed ready for product labels Feb 26, 2023
@jdingeman
Copy link
Member

jdingeman commented Feb 27, 2023

@ExperimentsInHonesty - added the point about the alt text that I meant to earler. I believe this issue is ready to go the backlog.

@jdingeman jdingeman added ready for product and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Feb 27, 2023
@Skydodle Skydodle self-assigned this Mar 1, 2023
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Hi @Skydodle, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@Skydodle
Copy link
Member

Skydodle commented Mar 1, 2023

Availability: Wednesday & Friday 7 to 9pm
ETA: Wednesday 3/8/2023

@Skydodle
Copy link
Member

Skydodle commented Mar 1, 2023

I have a blocker. I was able to use liquid to loop through partners.yml and render the images only if the organization's program-area value is "CItizen Engagement".

However, there is only one organization in partner.yml that is classified as "Citizen Engagement", vesus the original web page that has 8 organizations displayed. I just want to confirm if this is correct?

If you open partner.yml, only the first one (LA Department of Neighborhood Empowerment) has program-area as "Citizen Engagemnt".

Original page showing 8 organizations(hard coded):
Screenshot 2023-03-01 at 12 46 01 AM

Render based on partners.yml, only one:
Screenshot 2023-03-01 at 1 22 24 AM

@jdingeman
Copy link
Member

@Skydodle - that's a good catch. I can bring this up with Bonnie during leads meeting.

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Mar 3, 2023
@jdingeman
Copy link
Member

@Skydodle - go ahead and go with your solution. Product needs to update the partner list so that we can update our files accordingly. Your solutions shows the most accurate representation at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Refactor HTML P-Feature: Program Area https://www.hackforla.org/program-areas role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

5 participants