Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out naming convention for additional images #233

Closed
ExperimentsInHonesty opened this issue Dec 29, 2019 · 3 comments
Closed

Figure out naming convention for additional images #233

ExperimentsInHonesty opened this issue Dec 29, 2019 · 3 comments
Labels
Complexity: Missing Discussion Starting point for gathering further information and/or feedback Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing

Comments

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Dec 29, 2019

Overview

The project cards and future project home pages are fed content from the files in website/_projects. Inside of that file there is only one image designated.
image: /assets/images/projects/311.jpg.
we need to be able to specify multiple images for projects (banner, event photo, ???, etc.)

Action Items

Review suggested new file architecture sample for restructuring of image file convention and field names. Suggest changes or alternate, or approve.

Suggested new file architecture sample

image-pc: 311-pc.jpg . (pc stands for project card - we could spell it out too if we want)
image-banner: 311-banner.jpg
image-event-photo1: 311-photo1.jpg
image-event-photo2: 311-photo2.jpg
the reason I suggest using a number after the photo is in case there is an alternate they sometimes want to use. Like a specific banner if its earth day, etc. Or if they need more than one image and we latter make it possible for them to use multiple images loading in a certain locations (e.g., see the team in action photos section).

Resources/Instructions

example project mark down file for 311 project

@ExperimentsInHonesty ExperimentsInHonesty added the Discussion Starting point for gathering further information and/or feedback label Dec 29, 2019
@ExperimentsInHonesty
Copy link
Member Author

@ExperimentsInHonesty provide update

  1. Progress
  2. Blocks
  3. Availability
  4. ETA

@ExperimentsInHonesty
Copy link
Member Author

Decision made
image-card (for card on homepage)
image-hero (for image on project homepage)
mage-event-photo1: 311-photo1.jpg
image-event-photo2: 311-photo2.jpg

In order for this to be deployed. We need to do a new pull request that changes all the references to image to image-card in every project.md file and in the logic in the project include.

ETA end of 2/9.

@ExperimentsInHonesty
Copy link
Member Author

Proposal has been accepted
This is the "as-is" state after proposal acceptance.
image: 311-data.jpg (the original image for the project cards will remain unchanged for now)
image-hero: 311-data-hero.jpg
image-showcase: 311-data-showcase.jpg
image-event-photo1: 311-photo1.jpg
image-event-photo2: 311-photo2.jpg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Missing Discussion Starting point for gathering further information and/or feedback Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing
Projects
Development

No branches or pull requests

3 participants