-
-
Notifications
You must be signed in to change notification settings - Fork 33
Create table permission history 37 #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Create table permission history 37 #555
Conversation
50d1cab to
8b672ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks mostly good! I just have one question: why did you use CASCADE instead of PROTECT for the history table? Wouldn't we lose data if a user is deleted?
created_by and updated_by should be integers according to the issue.
@del9ra The CASCADE instead of PROTECT can be fixed easily. It should be PROTECT and I originally misunderstood how it worked at first but it's clearer now. For I can submit a change once resolved |
8b672ca to
3144807
Compare
3144807 to
c5a5cea
Compare
Fixes #37
What changes did you make?