Bugfix/484/enable single sign on for react app through people depot #485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
commit 0d70d8f Author: Ethan Strominger <ethanstrominger2@gmail.com> Date: Wed Dec 18 11:42:21 2024 -0500 Update graphviz commit 775d753 Author: Ethan Strominger <ethanstrominger2@gmail.com> Date: Sun Dec 1 17:25:56 2024 -0500 Modify to tricker pre-commit commit c75db16 Author: Ethan Strominger <ethanstrominger2@gmail.com> Date: Sun Dec 1 17:23:16 2024 -0500 Fix trailing whitespace
commit 0d70d8f Author: Ethan Strominger <ethanstrominger2@gmail.com> Date: Wed Dec 18 11:42:21 2024 -0500 Update graphviz commit 775d753 Author: Ethan Strominger <ethanstrominger2@gmail.com> Date: Sun Dec 1 17:25:56 2024 -0500 Modify to tricker pre-commit commit c75db16 Author: Ethan Strominger <ethanstrominger2@gmail.com> Date: Sun Dec 1 17:23:16 2024 -0500 Fix trailing whitespace
github-project-automation
bot
moved this to PR Needs review (automated column, do not place items here manually)
in P: PD: Project Board
github-project-automation
bot
moved this from PR Needs review (automated column, do not place items here manually)
to ✅Done
in P: PD: Project Board
…pp-through-People-Depot
…pp-through-People-Depot
github-project-automation
bot
moved this from ✅Done
to PR Needs review (automated column, do not place items here manually)
in P: PD: Project Board
fyliu
requested changes
Jun 1, 2025
There was a problem hiding this comment.
I see you're adding cors to allow a frontend to connect from a different domain, which is good.
I see a potential problem as well:
rest_framework.authtokenadds a separate token-based login method in addition to the one provided by cognito. I don't think it's something we want to do.
github-project-automation
bot
moved this from PR Needs review (automated column, do not place items here manually)
to PR changes requested
in P: PD: Project Board
|
@ethanstrominger is there a good way to test/validate this PR? |
|
This PR is not testable until the following issue is done: Converting it to draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #484
What changes did you make?
Dockerfile - updated graphiz versionChanged core.utils.jwt to core.utils.jwt_handler to disambiguate from the cors packageWhy did you make the changes?
Testing