bugfix: wrong test result for parameterized tests (microsoft#1027)

Author: jdneo

src/runners/junitRunner/JUnitRunnerResultAnalyzer.ts

@@ -65,7 +65,11 @@ export class JUnitRunnerResultAnalyzer extends BaseRunnerResultAnalyzer {
                     return;
                 }
                 if (finishedResult.status === TestStatus.Running) {
-                    finishedResult.status = TestStatus.Pass;
+                    if (finishedResult.trace) {
+                        finishedResult.status = TestStatus.Fail;
+                    } else {
+                        finishedResult.status = TestStatus.Pass;
+                    }
                 }
                 updateElapsedTime(finishedResult);
                 testResultManager.storeResult(finishedResult);

test/gradle-junit5-suite/codelens.test.ts

@@ -19,7 +19,7 @@ suite('Code Lens Tests', function() {
 
         const codeLensProvider: TestCodeLensProvider = new TestCodeLensProvider();
         const codeLens: CodeLens[] = await codeLensProvider.provideCodeLenses(document, Token.cancellationToken);
-        assert.equal(codeLens.length, 4, 'Code Lens should appear for @ParameterizedTest annotation');
+        assert.equal(codeLens.length, 6, 'Code Lens should appear for @ParameterizedTest annotation');
 
         const command: Command | undefined = codeLens[0].command;
         assert.notEqual(command, undefined, 'Command inside Code Lens should not be undefined');
@@ -39,6 +39,26 @@ suite('Code Lens Tests', function() {
         assert.ok(passedDetail!.duration !== undefined, 'Should have execution time');
     });
 
+    test("Can get correct result", async function() {
+        const document: TextDocument = await workspace.openTextDocument(Uris.GRADLE_JUNIT5_PARAMETERIZED_TEST);
+        await window.showTextDocument(document);
+
+        const codeLensProvider: TestCodeLensProvider = new TestCodeLensProvider();
+        const codeLens: CodeLens[] = await codeLensProvider.provideCodeLenses(document, Token.cancellationToken);
+
+        const command: Command | undefined = codeLens[2].command;
+
+        const testItem: ITestItem[] = command!.arguments as ITestItem[];
+
+        await commands.executeCommand(command!.command, testItem[0]);
+
+        const projectName: string = testItem[0].project;
+
+        const failedDetail: ITestResult| undefined = testResultManager.getResultById(`${projectName}@junit5.ParameterizedAnnotationTest#equal`);
+        assert.equal(failedDetail!.status, TestStatus.Fail);
+        assert.ok(failedDetail!.trace !== undefined, 'Should have error trace');
+    });
+
     test("Can run test method annotated with @Testable", async function() {
         const document: TextDocument = await workspace.openTextDocument(Uris.GRADLE_JUNIT5_PROPERTY_TEST);
         await window.showTextDocument(document);

test/test-projects/junit5/src/test/java/junit5/ParameterizedAnnotationTest.java

@@ -17,4 +17,13 @@ public void canRunWithComment(String str, Boolean bool) throws Exception {
         App classUnderTest = new App();
         assertEquals(classUnderTest.getGreeting().equals(str), bool);
     }
+
+    @ParameterizedTest
+    @CsvSource({
+        "1, 2",
+        "1, 1"
+    })
+    public void equal(int first, int second) throws Exception {
+        assertEquals(first, second);
+    }
 }