FW API: ajout endpoints + tri #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quentame
approved these changes
Nov 4, 2020
|
CI à corriger avant de merge |
|
Par contre le fail du test je le comprends pas ! |
En fait si :D |
oncleben31
approved these changes
Nov 11, 2020
Quentame
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changements :
get_port_forwarding_configuration➡️ sert maintenant à récup la config d'une règle précise selonredir_idget_all_port_forwarding_configuration➡️ était nommée avantget_port_forwarding_configuration(récup de toutes les redirections)get_incoming_ports_configuration➡️ sert maintenant à récup la config d'un port entrant ouvert précis selonport_idget_all_incoming_ports_configuration➡️ était nommée avantget_incoming_ports_configuration(récup de tous les ports ouverts en entrée)edit_port_forwarding_configuration➡️ Edition d'une règle précise selonredir_idLes breakings ne le sont pas dans HA, aucun de ces appels n'est utilisé ! Uniquement dans le cas d'un usage autre de la lib.
Tri des fonctions pour une meilleure lisibilité dans cet ordre si tous présents pour les 3 catégories (redirection, incoming, dmz) :