deps-dev(deps-dev): update numpy requirement from >=1.24.0 to >=2.0.2#33
deps-dev(deps-dev): update numpy requirement from >=1.24.0 to >=2.0.2#33dependabot[bot] wants to merge 1 commit into
Conversation
Updates the requirements on [numpy](https://github.com/numpy/numpy) to permit the latest version. - [Release notes](https://github.com/numpy/numpy/releases) - [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst) - [Commits](numpy/numpy@v1.24.0...v2.0.2) --- updated-dependencies: - dependency-name: numpy dependency-version: 2.0.2 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| ] | ||
| semantic = [ | ||
| "numpy>=1.24.0", | ||
| "numpy>=2.0.2", |
There was a problem hiding this comment.
🔴 numpy>=2.0.2 breaks declared Python 3.8 support
The project declares requires-python = ">=3.8" at pyproject.toml:12 and lists Python 3.8 in its classifiers (pyproject.toml:18). NumPy 2.0+ requires Python >=3.9, so there is no version of numpy that satisfies both >=2.0.2 and Python 3.8. Running pip install ocode[semantic] or pip install ocode[full] on Python 3.8 will fail with an unresolvable dependency. The previous floor of >=1.24.0 allowed pip to resolve to numpy 1.24.x on Python 3.8.
Prompt for agents
The numpy minimum version was bumped from 1.24.0 to 2.0.2, but the project still declares requires-python >= 3.8 (pyproject.toml:12) and lists Python 3.8 in classifiers (pyproject.toml:18). NumPy 2.0 dropped Python 3.8 support, so no resolution is possible for Python 3.8 users installing ocode[semantic] or ocode[full]. Either: (1) drop Python 3.8 support in requires-python and classifiers, or (2) use a version-conditional dependency like numpy>=1.24.0;python_version<'3.9' and numpy>=2.0.2;python_version>='3.9', or (3) keep the lower floor at >=1.24.0 so pip can resolve to an older numpy on Python 3.8.
Was this helpful? React with 👍 or 👎 to provide feedback.
| ] | ||
| semantic = [ | ||
| "numpy>=1.24.0", | ||
| "numpy>=2.0.2", |
There was a problem hiding this comment.
🟡 requirements-dev.txt numpy version not updated alongside pyproject.toml
The requirements-dev.txt:20 still specifies numpy>=1.24.0 while pyproject.toml:59 was bumped to numpy>=2.0.2. Developers using pip install -r requirements-dev.txt may install numpy <2.0.2, which could lead to inconsistent behavior or mask incompatibilities that would appear when users install via pip install ocode[semantic].
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Updates the requirements on numpy to permit the latest version.
Release notes
Sourced from numpy's releases.
... (truncated)
Commits
854252dMerge pull request #27280 from charris/prepare-2.0.2cffa071REL: Prepare for the NumPy 2.0.2 release [wheel build]1693029Merge pull request #27279 from charris/backport-27275da9f9c3BUG: Fix array_equal for numeric and non-numeric scalar typesee1cf96Merge pull request #27213 from charris/backport-2720249dec35BUG: Fix NPY_RAVEL_AXIS on backwards compatible NumPy 2 buildsbe56ae2Merge pull request #27195 from charris/backport-2718275b039cREV: Revert undef I and document it428e2baMerge pull request #27151 from charris/backport-27143451516dBUG: Do not accidentally store dtype metadata innp.saveDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)