deps-dev(deps-dev): update mypy requirement from >=1.0 to >=1.19.1#26
deps-dev(deps-dev): update mypy requirement from >=1.0 to >=1.19.1#26dependabot[bot] wants to merge 1 commit into
Conversation
Updates the requirements on [mypy](https://github.com/python/mypy) to permit the latest version. - [Changelog](https://github.com/python/mypy/blob/master/CHANGELOG.md) - [Commits](python/mypy@v1.0.0...v1.19.1) --- updated-dependencies: - dependency-name: mypy dependency-version: 1.19.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
| "black>=23.0", | ||
| "isort>=5.12", | ||
| "mypy>=1.0", | ||
| "mypy>=1.19.1", |
There was a problem hiding this comment.
🔴 mypy >=1.19.1 requires Python >=3.9, breaking dev install on declared-supported Python 3.8
mypy 1.19.1 declares Requires-Python: >=3.9, but this project declares requires-python = ">=3.8" at pyproject.toml:12 and lists Python 3.8 in its classifiers (pyproject.toml:18). A developer running Python 3.8 who runs pip install -e ".[dev]" will fail to install because pip cannot find a mypy version that satisfies both >=1.19.1 and Python 3.8. The mypy tool config also targets python_version = "3.8" (pyproject.toml:102). Either the minimum Python version should be bumped to 3.9+, or the mypy constraint should be relaxed (e.g., >=1.0) to allow older mypy on Python 3.8.
Prompt for agents
The project declares requires-python >= 3.8 (pyproject.toml:12) and lists Python 3.8 in classifiers (pyproject.toml:18), but mypy >= 1.19.1 requires Python >= 3.9. This means pip install -e .[dev] will fail on Python 3.8.
There are two paths to fix this:
1. If Python 3.8 support is still desired: relax the mypy constraint back to something compatible (e.g. mypy>=1.0 which was the previous value), or use an environment marker like mypy>=1.19.1; python_version>='3.9' combined with mypy>=1.0; python_version<'3.9'.
2. If Python 3.8 support can be dropped: bump requires-python to >=3.9, remove the 3.8 classifier, and update the python_version in [tool.mypy] and target-version in [tool.black].
Also note that requirements-dev.txt line 8 still has mypy>=1.0, which is inconsistent with pyproject.toml after this change.
Was this helpful? React with 👍 or 👎 to provide feedback.
Updates the requirements on mypy to permit the latest version.
Changelog
Sourced from mypy's changelog.
... (truncated)
Commits
412c19aBump version to 1.19.120aea0aUpdate changelog for 1.19.1 (#20414)2b23b50Serialize raw errors in cache metas (#20372)f60f90fFail on PyPy in main instead of setup.py (#20389)58d485bFail with an explicit error on PyPy (#20384)a4b31a2Allowtypes.NoneTypein match cases (#20383)8a6eff4[mypyc] fix generator regression with empty tuple (#20371)70eceeaFix noncommutative joins with bounded TypeVars (#20345)3890fc4Fix crash involving Unpack-ed TypeVarTuple (#20323)c93d917Fix crash on star import of redefinition (#20333)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)