It reports if command failed with an error

Author: ryu1kn

src/lib/command-wrapper.ts

@@ -27,6 +27,7 @@ export default class CommandWrapper {
     }
 
     private handleError(e: Error) {
+        this.telemetryReporter.logCommandErrored(this.name);
         this.logger.error(e.stack);
     }
 }

src/lib/telemetry-reporter.ts

@@ -3,6 +3,7 @@ import * as vscode from 'vscode';
 
 export interface TelemetryReporter extends vscode.Disposable {
     logCommandTrigger(commandName: string): void;
+    logCommandErrored(commandName: string): void;
 }
 
 export const createTelemetryReporter = (reporter?: VsTelemetryReporter) =>
@@ -19,6 +20,10 @@ class TelemetryReporterImpl implements TelemetryReporter {
         this.reporter.sendTelemetryEvent('commandTriggered', {commandName});
     }
 
+    logCommandErrored(commandName: string): void {
+        this.reporter.sendTelemetryEvent('commandErrored', {commandName});
+    }
+
     dispose(): void {
         this.reporter.dispose();
     }
@@ -28,6 +33,9 @@ class NullTelemetryReporter implements TelemetryReporter {
     logCommandTrigger(_commandName: string): void {
     }
 
+    logCommandErrored(_commandName: string): void {
+    }
+
     dispose(): void {
     }
 }

src/test/lib/command-wrapper.test.ts

@@ -32,7 +32,7 @@ suite('CommandWrapper', () => {
 
     setup(() => {
         logger = mockMethods<Logger>(['error']);
-        telemetryReporter = mockMethods<TelemetryReporter>(['logCommandTrigger']);
+        telemetryReporter = mockMethods<TelemetryReporter>(['logCommandTrigger', 'logCommandErrored']);
         commandWrapper = new CommandWrapper('COMMAND_NAME', command, telemetryReporter, logger);
     });
 
@@ -43,11 +43,13 @@ suite('CommandWrapper', () => {
     test('it logs a synchronously thrown error', async () => {
         await commandWrapper.execute(badSyncEditor);
         verify(logger.error(contains('Sync ERROR')));
+        verify(telemetryReporter.logCommandErrored('COMMAND_NAME'));
     });
 
     test('it logs an asynchronously thrown error', async () => {
         await commandWrapper.execute(badAsyncEditor);
         verify(logger.error(contains('Async ERROR')));
+        verify(telemetryReporter.logCommandErrored('COMMAND_NAME'));
     });
 
     test('it reports command invocation', async () => {