Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing small typos in agent_system_prompt #1916

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

svilupp
Copy link
Contributor

@svilupp svilupp commented Jan 3, 2025

Thanks for open-sourcing! It was a great read.

When going through the system prompt, I noticed some small typos, so I opened a PR:

  • there were typos in words (packages, a lot)
  • extra words (should be include)
  • missing punctuation
  • ? double spaces within bullets. I noticed too late that you have 2000 occurrences of those, so I should probably revert this change?

I didn't fix all grammar issues, just the big things that stood out as confusing. If it confuses me, it would confuse an LLM too.

Feel free to ignore/close if not helpful.

Copy link

sonarqubecloud bot commented Jan 3, 2025

Copy link
Collaborator

@pseudotensor pseudotensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pseudotensor pseudotensor merged commit 8e3a4df into h2oai:main Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants