Add zstd support #98
Merged
Add zstd support #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfergeau
added a commit
to cfergeau/crc
that referenced
this pull request
Jan 29, 2021
Testing[1] suggests that zstd compression might be better than xz, with decompression being much faster than xz, so it's worth considering it for our bundles. There is no native support for zstd in golang, so this makes use of https://pkg.go.dev/github.com/klauspost/compress/zstd for handling this format. An alternative would be https://github.com/DataDog/zstd which provides performance numbers, but which is not a pure go implementation, which is why I picked the other one. github.com/h2non/filetype does not support zstd type detection, so a bit of additional code had to be added for that. Before registering a zstd type, we check if it's supported, this will avoid potential issues after h2non/filetype#98 is merged. When compressed with `zstd --ultra -22 -T0`, the 4.6.9 bundle is 2.2G in size, and uncompresses in about 1 minute. The xz-compressed bundle is 2.6G in size, and takes 3 minutes to uncompress. An existing bundle can be converted to zstd for testing purposes with: xzcat $bundle |zstd - -o crc_libvirt_xxx.crcbundle This fixes crc-org#1340 for now.
|
Can you please add it to the README list? |
This adds support for detecting zstd compressed files https://en.wikipedia.org/wiki/Zstandard
Done! https://github.com/cfergeau/filetype/tree/zstd#archive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for detecting zstd archives
https://en.wikipedia.org/wiki/Zstandard