Replace some fixtures with provably free content (#46) #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that, as @aviau noted in #46, that at least the
sample.tif
file in the fixtures directory is non-free. The file contained a message right in the image: "This file is distributed with Techsoft PixEdit as a sample file, and is used with permission from the document owner." (That permission would NOT, in most countries' copyright law, implicitly extend to anyone OTHER than Techsoft.)Some of the other files in the directory appeared similarly suspect, or at least there was nothing to indicate that they ARE free content. And since there's an absolute wealth of free content out there, for at least certain formats, it just makes sense to use anything other than free content. So, this PR gets the ball rolling by replacing three "low-hanging fruit", including and especially the Techsoft TIF image.
sample.gif
is a CC-BY-SA licensed image via Wikimedia Commonssample.tif
is a public-domain Hubble Space Telescope image (thanks NASA!)sample.webm
is a CC-BY licensed video via Wikimedia CommonsThis change does not come without some tradeoffs in terms of file size.
sample.gif
grows from 3.3 KB to 390 KB, but it's a far better test file for itsample.webm
grows from ~ 230 KB to ~ 330 KB, fairly minorsample.tif
grows from 209 KB to an obscene 5 MB, and I do apologize for that, but one of the claims is that the tests are run on "real files", and it is hard to find SMAL "real" TIFF images. There is a strong bias for prioritizing quality and resolution over compactness when storing data in TIFF form. (I had to search through quite a few NASA galleries to find a file that small — others were tens or many hundreds of megabytes, some over a full gig!)I personally think the increased sizes are a reasonable tradeoff, and 5 MB in today's terms is really not that big a deal. But if it's unacceptably large, I can keep looking for a smaller replacement for at least the TIF file.
Last but not least, a new file
fixtures/sources.txt
provides provenance details for all three files, including the applicable free content license details and any required attributions.Partly addresses: #46