rubocops

Author: Sean OMeara

.rubocop.yml

@@ -13,9 +13,6 @@ MethodLength:
 LineLength:
   Enabled: false
 
-# HashSyntax:
-#  EnforcedStyle: hash_rockets
-
 Documentation:
   Enabled: false
 
@@ -37,3 +34,9 @@ AllCops:
 
 Style/GuardClause:
   Enabled: false
+
+Lint/HandleExceptions:
+  Enabled: false
+
+Metrics/ModuleLength:
+  Enabled: false

libraries/provider_mysql_service_smf.rb

@@ -4,8 +4,8 @@ class MysqlServiceSmf < Chef::Provider::MysqlServiceBase
       # FIXME: we should have a service_helper to determine if the platform supports SMF similarly
       # to how we handle systemd on linux
       if defined?(provides)
-        provides :mysql_service, os: %w(solaris2 omnios smartos openindiana opensolaris nexentacore) do |node|
-          File.exist?("/usr/sbin/svccfg")
+        provides :mysql_service, os: %w(solaris2 omnios smartos openindiana opensolaris nexentacore) do
+          File.exist?('/usr/sbin/svccfg')
         end
       end
 

libraries/provider_mysql_service_systemd.rb

@@ -4,7 +4,7 @@ class Chef
   class Provider
     class MysqlServiceSystemd < Chef::Provider::MysqlServiceBase
       if defined?(provides)
-        provides :mysql_service, os: 'linux' do |node|
+        provides :mysql_service, os: 'linux' do
           Chef::Platform::ServiceHelpers.service_resource_providers.include?(:systemd)
         end
       end

libraries/provider_mysql_service_upstart.rb

@@ -4,7 +4,7 @@ class Chef
   class Provider
     class MysqlServiceUpstart < Chef::Provider::MysqlServiceBase
       if defined?(provides)
-        provides :mysql_service, os: 'linux' do |node|
+        provides :mysql_service, os: 'linux' do
           Chef::Platform::ServiceHelpers.service_resource_providers.include?(:upstart) &&
             !Chef::Platform::ServiceHelpers.service_resource_providers.include?(:redhat)
         end

test/integration/client51/serverspec/assert_functioning_spec.rb

@@ -5,7 +5,7 @@
 puts "os: #{os}"
 
 def mysql_cmd
-  return "scl enable mysql51 \"mysql --version\"" if os[:family] == "redhat" && os[:release] =~ /^5\./
+  return "scl enable mysql51 \"mysql --version\"" if os[:family] == 'redhat' && os[:release] =~ /^5\./
   '/usr/bin/mysql --version'
 end
 

test/integration/client55/serverspec/assert_functioning_spec.rb

@@ -5,9 +5,9 @@
 puts "os: #{os}"
 
 def mysql_cmd
-  return "scl enable mysql55 \"mysql --version\"" if os[:family] == "redhat" && os[:release] =~ /^5\./
-  return '/opt/local/bin/mysql --version' if os[:family] == "smartos"
-  return '/opt/omni/bin/mysql --version' if os[:family] == "solaris"
+  return "scl enable mysql55 \"mysql --version\"" if os[:family] == 'redhat' && os[:release] =~ /^5\./
+  return '/opt/local/bin/mysql --version' if os[:family] == 'smartos'
+  return '/opt/omni/bin/mysql --version' if os[:family] == 'solaris'
   '/usr/bin/mysql --version'
 end
 

test/integration/client56/serverspec/assert_functioning_spec.rb

@@ -5,8 +5,8 @@
 puts "os: #{os}"
 
 def mysql_cmd
-  return '/opt/local/bin/mysql --version' if os[:family] == "smartos"
-  return '/opt/mysql56/bin/mysql --version' if os[:family] == "solaris"
+  return '/opt/local/bin/mysql --version' if os[:family] == 'smartos'
+  return '/opt/mysql56/bin/mysql --version' if os[:family] == 'solaris'
   '/usr/bin/mysql --version'
 end