forked from netty/netty
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
SPDY: handle too large header blocks
- Forward-ported 22b8a96
- Loading branch information
Showing
7 changed files
with
222 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
144 changes: 144 additions & 0 deletions
144
codec-http/src/test/java/io/netty/handler/codec/spdy/SpdyFrameDecoderTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| /* | ||
| * Copyright 2013 The Netty Project | ||
| * | ||
| * The Netty Project licenses this file to you under the Apache License, | ||
| * version 2.0 (the "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at: | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package io.netty.handler.codec.spdy; | ||
|
|
||
| import io.netty.bootstrap.Bootstrap; | ||
| import io.netty.bootstrap.ServerBootstrap; | ||
| import io.netty.channel.Channel; | ||
| import io.netty.channel.ChannelHandlerContext; | ||
| import io.netty.channel.ChannelInitializer; | ||
| import io.netty.channel.EventLoopGroup; | ||
| import io.netty.channel.SimpleChannelInboundHandler; | ||
| import io.netty.channel.nio.NioEventLoopGroup; | ||
| import io.netty.channel.socket.SocketChannel; | ||
| import io.netty.channel.socket.nio.NioServerSocketChannel; | ||
| import io.netty.channel.socket.nio.NioSocketChannel; | ||
| import io.netty.util.NetUtil; | ||
| import org.junit.AfterClass; | ||
| import org.junit.Test; | ||
|
|
||
| import java.net.InetSocketAddress; | ||
| import java.util.Arrays; | ||
| import java.util.List; | ||
|
|
||
| import static io.netty.handler.codec.spdy.SpdyConstants.*; | ||
| import static org.junit.Assert.*; | ||
|
|
||
| public class SpdyFrameDecoderTest { | ||
|
|
||
| private static final EventLoopGroup group = new NioEventLoopGroup(); | ||
|
|
||
| @AfterClass | ||
| public static void destroy() throws Exception { | ||
| group.shutdownGracefully().sync(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testTooLargeHeaderNameOnSynStreamRequest() throws Exception { | ||
| for (int version = SPDY_MIN_VERSION; version <= SPDY_MAX_VERSION; version++) { | ||
| final int finalVersion = version; | ||
| List<Integer> headerSizes = Arrays.asList(90, 900); | ||
| for (final int maxHeaderSize : headerSizes) { // 90 catches the header name, 900 the value | ||
| SpdyHeadersFrame frame = new DefaultSpdySynStreamFrame(1, 0, (byte) 0); | ||
| addHeader(frame, 100, 1000); | ||
| final CaptureHandler captureHandler = new CaptureHandler(); | ||
| ServerBootstrap sb = new ServerBootstrap(); | ||
| sb.group(group); | ||
| sb.channel(NioServerSocketChannel.class); | ||
| sb.childHandler(new ChannelInitializer<SocketChannel>() { | ||
| @Override | ||
| protected void initChannel(SocketChannel ch) throws Exception { | ||
| ch.pipeline().addLast( | ||
| new SpdyFrameDecoder(finalVersion, 10000, maxHeaderSize), | ||
| new SpdySessionHandler(finalVersion, true), | ||
| captureHandler); | ||
| } | ||
| }); | ||
|
|
||
| Bootstrap cb = new Bootstrap(); | ||
| cb.group(group); | ||
| cb.channel(NioSocketChannel.class); | ||
| cb.handler(new ChannelInitializer<SocketChannel>() { | ||
| @Override | ||
| protected void initChannel(SocketChannel ch) throws Exception { | ||
| ch.pipeline().addLast(new SpdyFrameEncoder(finalVersion)); | ||
| } | ||
| }); | ||
| Channel sc = sb.bind(0).sync().channel(); | ||
| int port = ((InetSocketAddress) sc.localAddress()).getPort(); | ||
|
|
||
| Channel cc = cb.connect(NetUtil.LOCALHOST, port).sync().channel(); | ||
|
|
||
| sendAndWaitForFrame(cc, frame, captureHandler); | ||
|
|
||
| assertNotNull("version " + version + ", not null message", | ||
| captureHandler.message); | ||
| String message = "version " + version + ", should be SpdyHeadersFrame, was " + | ||
| captureHandler.message.getClass(); | ||
| assertTrue( | ||
| message, | ||
| captureHandler.message instanceof SpdyHeadersFrame); | ||
| SpdyHeadersFrame writtenFrame = (SpdyHeadersFrame) captureHandler.message; | ||
|
|
||
| assertTrue("should be truncated", writtenFrame.isTruncated()); | ||
| assertFalse("should not be invalid", writtenFrame.isInvalid()); | ||
|
|
||
| sc.close().sync(); | ||
| cc.close().sync(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private static void sendAndWaitForFrame(Channel cc, SpdyFrame frame, CaptureHandler handler) { | ||
| cc.write(frame); | ||
| long theFuture = System.currentTimeMillis() + 3000; | ||
| while (handler.message == null && System.currentTimeMillis() < theFuture) { | ||
| try { | ||
| Thread.sleep(1); | ||
| } catch (InterruptedException e) { | ||
| // Ignore. | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private static void addHeader(SpdyHeadersFrame frame, int headerNameSize, int headerValueSize) { | ||
| frame.headers().add("k", "v"); | ||
| StringBuilder headerName = new StringBuilder(); | ||
| for (int i = 0; i < headerNameSize; i++) { | ||
| headerName.append('h'); | ||
| } | ||
| StringBuilder headerValue = new StringBuilder(); | ||
| for (int i = 0; i < headerValueSize; i++) { | ||
| headerValue.append('a'); | ||
| } | ||
| frame.headers().add(headerName.toString(), headerValue.toString()); | ||
| } | ||
|
|
||
| private static class CaptureHandler extends SimpleChannelInboundHandler<Object> { | ||
| public volatile Object message; | ||
|
|
||
| @Override | ||
| public void messageReceived(ChannelHandlerContext ctx, Object m) throws Exception { | ||
| message = m; | ||
| } | ||
|
|
||
| @Override | ||
| public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) throws Exception { | ||
| cause.printStackTrace(); | ||
| message = cause; | ||
| } | ||
| } | ||
| } |