Dockerize #40
Open
Dockerize #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if matches: | ||
| os.environ[matches.group(1)]=matches.group(2) | ||
| SAFE_ENV[matches.group(1)]=matches.group(2) | ||
| subprocess.check_call('ssh-add {}'.format(SSH_FILE_PATH), shell=True) |
There was a problem hiding this comment.
bandit: subprocess call with shell=True identified, security issue.
| if TRUSTED: | ||
| ssh_keygen() | ||
|
|
||
| SSH_KEY_HASH = hashlib.md5() |
There was a problem hiding this comment.
bandit: Use of insecure MD2, MD4, or MD5 hash function.
| ENV PATH /root/.pyenv/bin:$PATH | ||
| RUN eval "$(pyenv init -)" | ||
| RUN eval "$(pyenv virtualenv-init -)" | ||
| RUN pyenv update |
There was a problem hiding this comment.
You probably want the pyenv steps lower down in the dockerfile than the known hosts steps, since they're more likely to change. E.g. when you want to switch to a new python version.
There was a problem hiding this comment.
probably. the pyenv stuff isn't even working yet anyway, it still seems to be using the system python.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo: