From 081e71ce4e4c2f8b2e9992b5ac87ff33722c82e0 Mon Sep 17 00:00:00 2001 From: Gunschu <61991609+gunschu@users.noreply.github.com> Date: Fri, 2 Apr 2021 09:42:58 -0700 Subject: [PATCH 1/5] add Upgrade issue template --- .github/ISSUE_TEMPLATE/feature_request.md | 9 ++++++-- .../ISSUE_TEMPLATE/upgrade-dependencies.md | 23 +++++++++++++++++++ 2 files changed, 30 insertions(+), 2 deletions(-) create mode 100644 .github/ISSUE_TEMPLATE/upgrade-dependencies.md diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index e19a8497..88b49371 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -7,8 +7,13 @@ assignees: '' --- -**Is your feature request related to a problem? Please describe.** - +**Description** + + +**Is the feature supported by Jitsi?** +jitsi_meet Flutter plugin is dependent on the [Android](https://jitsi.github.io/handbook/docs/dev-guide/dev-guide-android-sdk) and [iOS](https://jitsi.github.io/handbook/docs/dev-guide/dev-guide-ios-sdk) SDK from jitsi.org. If those SDKs do not support a feature, we also can not add it. +* [ ] Yes: Paste link to Jitsi documentation here +* [ ] No **Describe the solution you'd like** diff --git a/.github/ISSUE_TEMPLATE/upgrade-dependencies.md b/.github/ISSUE_TEMPLATE/upgrade-dependencies.md new file mode 100644 index 00000000..6377d8a0 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/upgrade-dependencies.md @@ -0,0 +1,23 @@ +--- +name: UPGRADE DEPENDENCIES +about: Request to upgrade a dependency. +title: "[UPGRADE]: to " +labels: chore +assignees: tuantvu + +--- + +**Dependency Information** +Name: +Version: +Platform +* [ ] Android +* [ ] iOS +* [ ] Web + +**Reason for upgrade** + + +**Provide additional context** + From a4b4820788f73c84318921bb52f2c8d9a2bb3ff6 Mon Sep 17 00:00:00 2001 From: Gunschu <61991609+gunschu@users.noreply.github.com> Date: Fri, 2 Apr 2021 09:43:47 -0700 Subject: [PATCH 2/5] rename Upgrade template --- .github/ISSUE_TEMPLATE/upgrade-dependency.md | 23 ++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/upgrade-dependency.md diff --git a/.github/ISSUE_TEMPLATE/upgrade-dependency.md b/.github/ISSUE_TEMPLATE/upgrade-dependency.md new file mode 100644 index 00000000..0a3b5f93 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/upgrade-dependency.md @@ -0,0 +1,23 @@ +--- +name: Upgrade Dependency +about: Request to upgrade a dependency. +title: "[UPGRADE]: to " +labels: chore +assignees: tuantvu + +--- + +**Dependency Information** +Name: +Version: +Platform +* [ ] Android +* [ ] iOS +* [ ] Web + +**Reason for upgrade** + + +**Provide additional context** + From 615f6df4375ab7c00ce26c3ffcb3b60e76c2a003 Mon Sep 17 00:00:00 2001 From: Gunschu <61991609+gunschu@users.noreply.github.com> Date: Fri, 2 Apr 2021 09:44:19 -0700 Subject: [PATCH 3/5] Update issue templates --- .../ISSUE_TEMPLATE/upgrade-dependencies.md | 23 ------------------- 1 file changed, 23 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/upgrade-dependencies.md diff --git a/.github/ISSUE_TEMPLATE/upgrade-dependencies.md b/.github/ISSUE_TEMPLATE/upgrade-dependencies.md deleted file mode 100644 index 6377d8a0..00000000 --- a/.github/ISSUE_TEMPLATE/upgrade-dependencies.md +++ /dev/null @@ -1,23 +0,0 @@ ---- -name: UPGRADE DEPENDENCIES -about: Request to upgrade a dependency. -title: "[UPGRADE]: to " -labels: chore -assignees: tuantvu - ---- - -**Dependency Information** -Name: -Version: -Platform -* [ ] Android -* [ ] iOS -* [ ] Web - -**Reason for upgrade** - - -**Provide additional context** - From bfb3a6fd1b1375627245cd592ce490b3170fc634 Mon Sep 17 00:00:00 2001 From: Gunschu <61991609+gunschu@users.noreply.github.com> Date: Fri, 2 Apr 2021 09:56:17 -0700 Subject: [PATCH 4/5] Update pull request template --- .github/PULL_REQUEST_TEMPLATE/pull_request_template.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md index 9406bf01..9b5aec34 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -1,5 +1,5 @@ ### Description - + ### Type of change, choose all that apply. * [ ] breaking @@ -10,6 +10,11 @@ * [ ] tests * [ ] chore (e.g. upgrade of dependencies) +### Test artifacts +Since we do not yet have automated testing please include the following to speed up the review process. +* [ ] Video or screenshots of the functionality, bug fix, or regression testing: +* [ ] Environments tested in (device, version, etc): + ### Have you updated documentation? * [ ] yes -* [ ] no \ No newline at end of file +* [ ] no From 71207a9caaa5ab35d596b53503cefd43aeff8329 Mon Sep 17 00:00:00 2001 From: Gunschu <61991609+gunschu@users.noreply.github.com> Date: Fri, 2 Apr 2021 09:57:34 -0700 Subject: [PATCH 5/5] Update pull_request_template.md --- .github/PULL_REQUEST_TEMPLATE/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md index 9b5aec34..b895e76b 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -1,7 +1,7 @@ ### Description -### Type of change, choose all that apply. +### Type of change, choose all that apply. (Put an 'x' in the boxes) * [ ] breaking * [ ] fix * [ ] feature