Update eslint & remove jscs

Author: gucong3000

.eslintrc

@@ -1,3 +1,7 @@
 {
-  "extends": "gulp"
+  "root": true,
+  "extends": [
+    "standard",
+    "gulp"
+  ]
 }

.jscsrc

@@ -8,7 +8,7 @@ var nonEnum = ['message', 'name', 'stack'];
 var ignored = union(nonEnum, ['__safety', '_stack', 'plugin', 'showProperties', 'showStack']);
 var props = ['fileName', 'lineNumber', 'message', 'name', 'plugin', 'showProperties', 'showStack', 'stack'];
 
-function PluginError(plugin, message, options) {
+function PluginError (plugin, message, options) {
   if (!(this instanceof PluginError)) {
     throw new Error('Call PluginError using new');
   }
@@ -22,13 +22,13 @@ function PluginError(plugin, message, options) {
     var keys = union(Object.keys(opts.error), nonEnum);
 
     // These properties are not enumerable, so we have to add them explicitly.
-    keys.forEach(function(prop) {
+    keys.forEach(function (prop) {
       self[prop] = opts.error[prop];
     });
   }
 
   // Opts object can override
-  props.forEach(function(prop) {
+  props.forEach(function (prop) {
     if (prop in opts) {
       this[prop] = opts[prop];
     }
@@ -39,7 +39,6 @@ function PluginError(plugin, message, options) {
     this.name = 'Error';
   }
   if (!this.stack) {
-
     /**
      * `Error.captureStackTrace` appends a stack property which
      * relies on the toString method of the object it is applied to.
@@ -50,10 +49,11 @@ function PluginError(plugin, message, options) {
      */
 
     var safety = {};
-    safety.toString = function() {
+    safety.toString = function () {
       return this._messageWithDetails() + '\nStack:';
     }.bind(this);
 
+    // eslint-disable-next-line no-caller
     Error.captureStackTrace(safety, arguments.callee || this.constructor);
     this.__safety = safety;
   }
@@ -71,7 +71,7 @@ util.inherits(PluginError, Error);
  * Output a formatted message with details
  */
 
-PluginError.prototype._messageWithDetails = function() {
+PluginError.prototype._messageWithDetails = function () {
   var msg = 'Message:\n    ' + this.message;
   var details = this._messageDetails();
   if (details !== '') {
@@ -84,7 +84,7 @@ PluginError.prototype._messageWithDetails = function() {
  * Output actual message details
  */
 
-PluginError.prototype._messageDetails = function() {
+PluginError.prototype._messageDetails = function () {
   if (!this.showProperties) {
     return '';
   }
@@ -111,8 +111,8 @@ PluginError.prototype._messageDetails = function() {
  * Override the `toString` method
  */
 
-PluginError.prototype.toString = function() {
-  var detailsWithStack = function(stack) {
+PluginError.prototype.toString = function () {
+  var detailsWithStack = function (stack) {
     return this._messageWithDetails() + '\nStack:\n' + stack;
   }.bind(this);
 
@@ -121,10 +121,8 @@ PluginError.prototype.toString = function() {
     // If there is no wrapped error, use the stack captured in the PluginError ctor
     if (this.__safety) {
       msg = this.__safety.stack;
-
     } else if (this._stack) {
       msg = detailsWithStack(this._stack);
-
     } else {
       // Stack from wrapped error
       msg = detailsWithStack(this.stack);
@@ -137,7 +135,7 @@ PluginError.prototype.toString = function() {
 };
 
 // Format the output message
-function message(msg, thisArg) {
+function message (msg, thisArg) {
   var sig = colors.red(thisArg.name);
   sig += ' in plugin ';
   sig += '"' + colors.cyan(thisArg.plugin) + '"';
@@ -150,7 +148,7 @@ function message(msg, thisArg) {
  * Set default options based on arguments.
  */
 
-function setDefaults(plugin, message, opts) {
+function setDefaults (plugin, message, opts) {
   if (typeof plugin === 'object') {
     return defaults(plugin);
   }
@@ -176,10 +174,10 @@ function setDefaults(plugin, message, opts) {
  * @return {Object}
  */
 
-function defaults(opts) {
+function defaults (opts) {
   return extend({
     showStack: false,
-    showProperties: true,
+    showProperties: true
   }, opts);
 }
 

index.js

@@ -19,8 +19,8 @@
     "index.js"
   ],
   "scripts": {
-    "lint": "eslint . && jscs index.js test/",
-    "pretest": "npm run lint",
+    "lint:eslint": "eslint .",
+    "pretest": "npm-run-all --parallel lint:*",
     "test": "mocha --async-only && npm run test-types",
     "test-types": "tsc -p test/types",
     "cover": "istanbul cover _mocha --report lcovonly",
@@ -33,14 +33,18 @@
     "extend-shallow": "^3.0.2"
   },
   "devDependencies": {
-    "eslint": "^1.7.3",
-    "eslint-config-gulp": "^2.0.0",
+    "eslint": "^4.16.0",
+    "eslint-config-gulp": "github:BurtHarris/eslint-config-gulp#workitem_10",
+    "eslint-config-standard": "^11.0.0-beta.0",
+    "eslint-plugin-import": "^2.8.0",
+    "eslint-plugin-node": "^5.2.1",
+    "eslint-plugin-promise": "^3.6.0",
+    "eslint-plugin-standard": "^3.0.1",
     "expect": "^1.20.2",
     "istanbul": "^0.4.3",
     "istanbul-coveralls": "^1.0.3",
-    "jscs": "^2.3.5",
-    "jscs-preset-gulp": "^1.0.0",
     "mocha": "^3.0.0",
+    "npm-run-all": "^4.1.2",
     "typescript": "^2.6.2"
   },
   "keywords": [

package.json

@@ -1,3 +1,5 @@
 {
-  "extends": "gulp/test"
+  "env": {
+    "mocha": true
+  }
 }

test/.eslintrc

@@ -4,75 +4,75 @@ var expect = require('expect');
 
 var PluginError = require('../');
 
-describe('PluginError()', function() {
-  it('should default name to Error', function(done) {
+describe('PluginError()', function () {
+  it('should default name to Error', function (done) {
     var err = new PluginError('test', 'something broke');
     expect(err.name).toEqual('Error');
     done();
   });
 
-  it('should default name to Error, even when wrapped error has no name', function(done) {
+  it('should default name to Error, even when wrapped error has no name', function (done) {
     var realErr = { message: 'something broke' };
     var err = new PluginError('test', realErr);
     expect(err.name).toEqual('Error');
     done();
   });
 
-  it('should print the plugin name in toString', function(done) {
+  it('should print the plugin name in toString', function (done) {
     var err = new PluginError('test', 'something broke');
     expect(err.toString()).toContain('test');
     done();
   });
 
-  it('should not include the stack by default in toString', function(done) {
+  it('should not include the stack by default in toString', function (done) {
     var err = new PluginError('test', 'something broke');
     // Just check that there are no 'at' lines
     expect(err.toString()).toNotContain('at');
     done();
   });
 
-  it('should include the stack when specified in toString', function(done) {
+  it('should include the stack when specified in toString', function (done) {
     var err = new PluginError('test', 'something broke', { stack: 'at huh', showStack: true });
     // Just check that there are 'at' lines
     expect(err.toString()).toContain('at');
     done();
   });
 
-  it('should take arguments as one object', function(done) {
+  it('should take arguments as one object', function (done) {
     var err = new PluginError({
       plugin: 'test',
-      message: 'something broke',
+      message: 'something broke'
     });
     expect(err.plugin).toEqual('test');
     expect(err.message).toEqual('something broke');
     done();
   });
 
-  it('should take arguments as plugin name and one object', function(done) {
+  it('should take arguments as plugin name and one object', function (done) {
     var err = new PluginError('test', {
-      message: 'something broke',
+      message: 'something broke'
     });
     expect(err.plugin).toEqual('test');
     expect(err.message).toEqual('something broke');
     done();
   });
 
-  it('should take arguments as plugin name and message', function(done) {
+  it('should take arguments as plugin name and message', function (done) {
     var err = new PluginError('test', 'something broke');
     expect(err.plugin).toEqual('test');
     expect(err.message).toEqual('something broke');
     done();
   });
 
-  it('should take arguments as plugin name, message, and one object', function(done) {
+  it('should take arguments as plugin name, message, and one object', function (done) {
     var err = new PluginError('test', 'something broke', { showStack: true });
     expect(err.plugin).toEqual('test');
     expect(err.message).toEqual('something broke');
     expect(err.showStack).toEqual(true);
     done();
   });
 
-  it('should take arguments as plugin name, error, and one object', function(done) {
+  it('should take arguments as plugin name, error, and one object', function (done) {
     var realErr = new Error('something broke');
     realErr.fileName = 'original.js';
     var err = new PluginError('test', realErr, { showStack: true, fileName: 'override.js' });
@@ -83,7 +83,7 @@ describe('PluginError()', function() {
     done();
   });
 
-  it('should take properties from error', function(done) {
+  it('should take properties from error', function (done) {
     var realErr = new Error('something broke');
     realErr.abstractProperty = 'abstract';
     var err = new PluginError('test', realErr);
@@ -93,19 +93,19 @@ describe('PluginError()', function() {
     done();
   });
 
-  it('should be configured to show properties by default', function(done) {
+  it('should be configured to show properties by default', function (done) {
     var err = new PluginError('test', 'something broke');
     expect(err.showProperties).toBe(true);
     done();
   });
 
-  it('should not be configured to take option to show properties', function(done) {
+  it('should not be configured to take option to show properties', function (done) {
     var err = new PluginError('test', 'something broke', { showProperties: false });
     expect(err.showProperties).toBe(false);
     done();
   });
 
-  it('should show properties', function(done) {
+  it('should show properties', function (done) {
     var err = new PluginError('test', 'it broke', { showProperties: true });
     err.fileName = 'original.js';
     err.lineNumber = 35;
@@ -115,7 +115,7 @@ describe('PluginError()', function() {
     done();
   });
 
-  it('should show properties', function(done) {
+  it('should show properties', function (done) {
     var realErr = new Error('something broke');
     realErr.fileName = 'original.js';
     realErr.lineNumber = 35;
@@ -125,7 +125,7 @@ describe('PluginError()', function() {
     done();
   });
 
-  it('should not show properties', function(done) {
+  it('should not show properties', function (done) {
     var realErr = new Error('something broke');
     realErr.fileName = 'original.js';
     realErr.lineNumber = 35;
@@ -135,7 +135,7 @@ describe('PluginError()', function() {
     done();
   });
 
-  it('should not show properties, but should show stack', function(done) {
+  it('should not show properties, but should show stack', function (done) {
     var err = new PluginError('test', 'it broke', { stack: 'test stack', showStack: true, showProperties: false });
     err.fileName = 'original.js';
     err.lineNumber = 35;
@@ -145,7 +145,7 @@ describe('PluginError()', function() {
     done();
   });
 
-  it('should not show properties, but should show stack for real error', function(done) {
+  it('should not show properties, but should show stack for real error', function (done) {
     var realErr = new Error('something broke');
     realErr.fileName = 'original.js';
     realErr.lineNumber = 35;
@@ -157,7 +157,7 @@ describe('PluginError()', function() {
     done();
   });
 
-  it('should not show properties, but should show stack for _stack', function(done) {
+  it('should not show properties, but should show stack for _stack', function (done) {
     var realErr = new Error('something broke');
     realErr.fileName = 'original.js';
     realErr.lineNumber = 35;
@@ -169,7 +169,7 @@ describe('PluginError()', function() {
     done();
   });
 
-  it('should show properties and stack', function(done) {
+  it('should show properties and stack', function (done) {
     var realErr = new Error('something broke');
     realErr.fileName = 'original.js';
     realErr.stack = 'test stack';
@@ -180,7 +180,7 @@ describe('PluginError()', function() {
     done();
   });
 
-  it('should show properties added after the error is created', function(done) {
+  it('should show properties added after the error is created', function (done) {
     var realErr = new Error('something broke');
     var err = new PluginError('test', realErr);
     err.fileName = 'original.js';
@@ -189,7 +189,7 @@ describe('PluginError()', function() {
     done();
   });
 
-  it('should toString quickly', function(done) {
+  it('should toString quickly', function (done) {
     this.timeout(100);
 
     var err = new PluginError('test', 'it broke', { showStack: true });
@@ -198,7 +198,7 @@ describe('PluginError()', function() {
     done();
   });
 
-  it('should toString quickly with original error', function(done) {
+  it('should toString quickly with original error', function (done) {
     this.timeout(100);
 
     var realErr = new Error('it broke');
@@ -208,7 +208,7 @@ describe('PluginError()', function() {
     done();
   });
 
-  it('should not show "Details:" if there are no properties to show', function(done) {
+  it('should not show "Details:" if there are no properties to show', function (done) {
     var err = new PluginError('plugin', 'message');
     expect(err.toString().indexOf('Details:')).toEqual(-1);
     done();