Changed tests to truly go off the toString method and fixed resulting failures

Author: mtscout6

lib/PluginError.js

@@ -60,7 +60,7 @@ function PluginError(plugin, message, opt) {
     // safety object, then we'll get stack overflow problems.
     var safety = {
       toString: function() {
-        return this.messageDetails + '\nStack:';
+        return this.messageWithDetails + '\nStack:';
       }.bind(this)
     };
     Error.captureStackTrace(safety, arguments.callee || this.constructor);
@@ -73,17 +73,26 @@ function PluginError(plugin, message, opt) {
 
 util.inherits(PluginError, Error);
 
+PluginError.prototype.__defineGetter__('messageWithDetails', function() {
+  var details = this.messageDetails;
+
+  if (details === '') {
+    return 'Message:\t    ' + this.message;
+  }
+
+  return 'Message:\t    ' + this.message + '\n' + details;
+});
+
 PluginError.prototype.__defineGetter__('messageDetails', function() {
-  debugger;
   if (this.showProperties) {
     var res = _(Object.keys(this))
     .filter(function(prop) { return propertiesNotToDisplay.indexOf(prop) === -1; })
     .map(function(prop) { return '\n    ' + prop + ': ' + this[prop]; }, this)
     .reduce(function(properties, next) { return properties + next; });
 
-    return 'Message:\n    ' + this.message + '\nDetails:' + res;
+    return 'Details:' + res;
   } else {
-    return 'Message:\n    ' + this.message;
+    return '';
   }
 });
 
@@ -94,9 +103,9 @@ PluginError.prototype.toString = function () {
     if (this.__safety) {
       msg = this.__safety.stack;
     } else if (this._stack) {
-      msg = this._stack;
+      msg = this.messageWithDetails + '\n' + this._stack;
     } else {
-      msg = this.stack;
+      msg = this.messageWithDetails + '\n' + this.stack;
     }
   } else {
     msg = this.messageDetails;

test/PluginError.js

@@ -102,16 +102,16 @@ describe('PluginError()', function(){
     var realErr = new Error('something broke');
     realErr.fileName = 'original.js';
     var err = new util.PluginError('test', realErr, {showStack: true});
-    err.messageDetails.indexOf('message:').should.equal(-1);
-    err.messageDetails.indexOf('fileName:').should.not.equal(-1);
+    err.toString().indexOf('message:').should.equal(-1);
+    err.toString().indexOf('fileName:').should.not.equal(-1);
   });
 
   it('should show properties added after the error is created', function(){
     var realErr = new Error('something broke');
     var err = new util.PluginError('test', realErr);
     err.fileName = 'original.js';
-    err.messageDetails.indexOf('message:').should.equal(-1);
-    err.messageDetails.indexOf('fileName:').should.not.equal(-1);
+    err.toString().indexOf('message:').should.equal(-1);
+    err.toString().indexOf('fileName:').should.not.equal(-1);
   });
 
   it('should toString quickly', function(done) {