feat!: question marks are valid path characters on Windows so avoid f…

…lagging as a glob when alone
gulpjs · Jan 27, 2021 · 2a551dd · 2a551dd
1 parent e41fcd8
commit 2a551dd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -44,7 +44,7 @@ Takes a string and returns the part of the path before the glob begins. Be aware
 
 The following characters have special significance in glob patterns and must be escaped if you want them to be treated as regular path characters:
 
-- `?` (question mark)
+- `?` (question mark) unless used as a path segment alone
 - `*` (asterisk)
 - `|` (pipe)
 - `(` (opening parenthesis)

diff --git a/test/index.test.js b/test/index.test.js
@@ -47,12 +47,12 @@ describe('glob-parent', function() {
     assert.equal(gp('path/*(to|from)'), 'path');
     assert.equal(gp('path/@(to|from)'), 'path');
     assert.equal(gp('path/!/foo'), 'path/!');
-    assert.equal(gp('path/?/foo'), 'path', 'qmarks must be escaped');
+    assert.equal(gp('path/?/foo'), 'path/?');
     assert.equal(gp('path/+/foo'), 'path/+');
     assert.equal(gp('path/*/foo'), 'path');
     assert.equal(gp('path/@/foo'), 'path/@');
     assert.equal(gp('path/!/foo/'), 'path/!/foo');
-    assert.equal(gp('path/?/foo/'), 'path', 'qmarks must be escaped');
+    assert.equal(gp('path/?/foo/'), 'path/?/foo');
     assert.equal(gp('path/+/foo/'), 'path/+/foo');
     assert.equal(gp('path/*/foo/'), 'path');
     assert.equal(gp('path/@/foo/'), 'path/@/foo');