Skip to content

Commit 7d40dfb

Browse files
committed
Update: Switch to mocha + expect for testing
1 parent 7b66aab commit 7d40dfb

File tree

8 files changed

+40
-52
lines changed

8 files changed

+40
-52
lines changed

.travis.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
sudo: false
2-
32
language: node_js
4-
53
node_js:
6-
- '0.10'
4+
- '6'
5+
- '5'
6+
- '4'
77
- '0.12'
8-
- 'stable'
8+
- '0.10'
9+
after_script:
10+
- npm run coveralls

package.json

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,11 @@
1919
"LICENSE"
2020
],
2121
"scripts": {
22-
"lint": "eslint . && jscs *.js test/",
23-
"test": "lab -cv"
22+
"lint": "eslint . && jscs index.js test/",
23+
"pretest": "npm run lint",
24+
"test": "mocha --async-only",
25+
"cover": "istanbul cover _mocha --report lcovonly",
26+
"coveralls": "npm run cover && istanbul-coveralls"
2427
},
2528
"dependencies": {
2629
"end-of-stream": "^1.1.0",
@@ -29,12 +32,14 @@
2932
"stream-exhaust": "^1.0.1"
3033
},
3134
"devDependencies": {
32-
"code": "^1.4.1",
3335
"eslint": "^1.7.3",
3436
"eslint-config-gulp": "^2.0.0",
37+
"expect": "^1.19.0",
38+
"istanbul": "^0.4.3",
39+
"istanbul-coveralls": "^1.0.3",
3540
"jscs": "^2.3.5",
3641
"jscs-preset-gulp": "^1.0.0",
37-
"lab": "^6.2.0",
42+
"mocha": "^2.4.5",
3843
"rx": "^4.0.6",
3944
"through2": "^2.0.0",
4045
"when": "^3.7.3"

test/arguments.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
'use strict';
22

3-
var lab = exports.lab = require('lab').script();
4-
var describe = lab.describe;
5-
var it = lab.it;
6-
var expect = require('code').expect;
3+
var expect = require('expect');
74

85
var asyncDone = require('../');
96

@@ -15,8 +12,8 @@ describe('arguments', function() {
1512

1613
it('passes all arguments to the completion callback', function(done) {
1714
asyncDone(twoArg, function(err, arg1, arg2) {
18-
expect(arg1).to.equal(1);
19-
expect(arg2).to.equal(2);
15+
expect(arg1).toEqual(1);
16+
expect(arg2).toEqual(2);
2017
done(err);
2118
});
2219
});

test/callbacks.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
'use strict';
22

3-
var lab = exports.lab = require('lab').script();
4-
var describe = lab.describe;
5-
var it = lab.it;
6-
var expect = require('code').expect;
3+
var expect = require('expect');
74

85
var asyncDone = require('../');
96

@@ -23,14 +20,14 @@ describe('callbacks', function() {
2320

2421
it('should handle a successful callback', function(done) {
2522
asyncDone(success, function(err, result) {
26-
expect(result).to.equal(2);
23+
expect(result).toEqual(2);
2724
done(err);
2825
});
2926
});
3027

3128
it('should handle an errored callback', function(done) {
3229
asyncDone(failure, function(err) {
33-
expect(err).to.be.instanceof(Error);
30+
expect(err).toBeAn(Error);
3431
done();
3532
});
3633
});
@@ -48,7 +45,7 @@ describe('callbacks', function() {
4845
it('should not handle error if something throws inside the callback', function(done) {
4946
var d = require('domain').create();
5047
d.on('error', function(err) {
51-
expect(err).to.be.instanceof(Error);
48+
expect(err).toBeAn(Error);
5249
done();
5350
});
5451

test/child_processes.js

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
'use strict';
22

3-
var lab = exports.lab = require('lab').script();
4-
var describe = lab.describe;
5-
var it = lab.it;
6-
var expect = require('code').expect;
3+
var expect = require('expect');
74

85
var cp = require('child_process');
96
var asyncDone = require('../');
@@ -28,28 +25,28 @@ function spawnFail() {
2825
describe('child processes', function() {
2926
it('should handle successful exec', function(done) {
3027
asyncDone(execSuccess, function(err) {
31-
expect(err).to.not.be.instanceof(Error);
28+
expect(err).toNotBeAn(Error);
3229
done();
3330
});
3431
});
3532

3633
it('should handle failing exec', function(done) {
3734
asyncDone(execFail, function(err) {
38-
expect(err).to.be.an.instanceof(Error);
35+
expect(err).toBeAn(Error);
3936
done();
4037
});
4138
});
4239

4340
it('should handle successful spawn', function(done) {
4441
asyncDone(spawnSuccess, function(err) {
45-
expect(err).to.not.be.instanceof(Error);
42+
expect(err).toNotBeAn(Error);
4643
done();
4744
});
4845
});
4946

5047
it('should handle failing spawn', function(done) {
5148
asyncDone(spawnFail, function(err) {
52-
expect(err).to.be.an.instanceof(Error);
49+
expect(err).toBeAn(Error);
5350
done();
5451
});
5552
});

test/observables.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
'use strict';
22

3-
var lab = exports.lab = require('lab').script();
4-
var describe = lab.describe;
5-
var it = lab.it;
6-
var expect = require('code').expect;
3+
var expect = require('expect');
74

85
var asyncDone = require('../');
96

@@ -25,21 +22,21 @@ describe('observables', function() {
2522

2623
it('should handle a finished observable', function(done) {
2724
asyncDone(success, function(err, result) {
28-
expect(result).to.equal(undefined);
25+
expect(result).toEqual(undefined);
2926
done(err);
3027
});
3128
});
3229

3330
it('should handle a finished observable with value', function(done) {
3431
asyncDone(successValue, function(err, result) {
35-
expect(result).to.equal(42);
32+
expect(result).toEqual(42);
3633
done(err);
3734
});
3835
});
3936

4037
it('should handle an errored observable', function(done) {
4138
asyncDone(failure, function(err) {
42-
expect(err).to.be.instanceof(Error);
39+
expect(err).toBeAn(Error);
4340
done();
4441
});
4542
});

test/promises.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
'use strict';
22

3-
var lab = exports.lab = require('lab').script();
4-
var describe = lab.describe;
5-
var it = lab.it;
6-
var expect = require('code').expect;
3+
var expect = require('expect');
74

85
var when = require('when');
96

@@ -21,14 +18,14 @@ describe('promises', function() {
2118

2219
it('should handle a resolved promise', function(done) {
2320
asyncDone(success, function(err, result) {
24-
expect(result).to.equal(2);
21+
expect(result).toEqual(2);
2522
done(err);
2623
});
2724
});
2825

2926
it('should handle a rejected promise', function(done) {
3027
asyncDone(failure, function(err) {
31-
expect(err).to.be.instanceof(Error);
28+
expect(err).toBeAn(Error);
3229
done();
3330
});
3431
});

test/streams.js

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,8 @@
11
'use strict';
22

3-
var lab = exports.lab = require('lab').script();
4-
var describe = lab.describe;
5-
var it = lab.it;
6-
var expect = require('code').expect;
3+
var expect = require('expect');
74

85
var fs = require('fs');
9-
var cp = require('child_process');
106
var path = require('path');
117
var through = require('through2');
128

@@ -40,14 +36,14 @@ function unpiped() {
4036
describe('streams', function() {
4137
it('should handle a successful stream', function(done) {
4238
asyncDone(success, function(err) {
43-
expect(err).to.not.be.instanceof(Error);
39+
expect(err).toNotBeAn(Error);
4440
done();
4541
});
4642
});
4743

4844
it('should handle an errored stream', function(done) {
4945
asyncDone(failure, function(err) {
50-
expect(err).to.be.instanceof(Error);
46+
expect(err).toBeAn(Error);
5147
done();
5248
});
5349
});
@@ -58,15 +54,15 @@ describe('streams', function() {
5854
cb(null, 3);
5955
});
6056
}, function(err, result) {
61-
expect(err).to.not.be.instanceof(Error);
62-
expect(result).to.equal(3); // To know we called the callback
57+
expect(err).toNotBeAn(Error);
58+
expect(result).toEqual(3); // To know we called the callback
6359
done();
6460
});
6561
});
6662

6763
it('consumes an unpiped readable stream', function(done) {
6864
asyncDone(unpiped, function(err) {
69-
expect(err).to.not.be.instanceof(Error);
65+
expect(err).toNotBeAn(Error);
7066
done();
7167
});
7268
});

0 commit comments

Comments
 (0)