Fix: Callback with an error even if Promise is rejected with nothing (c…

…loses #42)
gulpjs · Aug 4, 2017 · 77d00f9 · 77d00f9
1 parent cca775b
commit 77d00f9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -29,6 +29,9 @@ function asyncDone(fn, cb) {
   }
 
   function onError(error) {
+    if (!error) {
+      error = new Error('Promise rejected without Error');
+    }
     return done(error);
   }
 

diff --git a/test/promises.js b/test/promises.js
@@ -14,6 +14,10 @@ function failure() {
   return when.reject(new Error('Promise Error'));
 }
 
+function rejectNoError() {
+  return when.reject();
+}
+
 describe('promises', function() {
 
   it('should handle a resolved promise', function(done) {
@@ -29,4 +33,12 @@ describe('promises', function() {
       done();
     });
   });
+
+  it('properly errors when rejected without an error', function(done) {
+    asyncDone(rejectNoError, function(err) {
+      expect(err).toExist();
+      expect(err).toBeAn(Error);
+      done();
+    });
+  });
 });